Use JReleaser to release artifacts in Maven Central #194
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jnmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the project's build and release process by integrating JReleaser. The primary goal is to automate and streamline the deployment of artifacts to Maven Central, centralizing the configuration for both release and snapshot versions and removing the need for manual publishing and signing logic in individual subprojects.
Highlights
- JReleaser Integration: The
org.jreleaserGradle plugin has been introduced and extensively configured inbuild.gradleto manage artifact releases. - Centralized Release Configuration: JReleaser is now responsible for deploying artifacts to Maven Central (via Sonatype) for releases and to Nexus2 for snapshots, including automatic signing of artifacts.
- Simplified Subproject Publishing: The
archive.gradlefiles forclient,common,ledger, andrpchave been simplified by removing redundant Maven publishing and signing configurations, as these are now handled by JReleaser. - Gradle Wrapper Update: The Gradle wrapper version has been updated from 7.6.1 to 7.6.6 in
gradle/wrapper/gradle-wrapper.properties.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR introduces JReleaser for Maven Central artifact releases. Version management is centralized, and JReleaser is configured for both release and snapshot deployments. Suggestions include reducing code duplication in build.gradle and removing redundancy in archive.gradle.
jnmt
requested review from
brfrn169,
choplin,
Copilot,
feeblefakie and
kota2and3kan
There was a problem hiding this comment.
Pull Request Overview
This PR replaces manual Sonatype staging and signing in each module with a local staging-deploy directory and adds JReleaser to publish artifacts to Maven Central. It also bumps the Gradle wrapper version and updates GitHub Actions workflows to use JReleaser.
- Consolidates per-module Maven repository configs to a local staging directory
- Updates Gradle wrapper from 7.6.1 to 7.6.6
- Replaces manual publish/signing steps in GitHub Actions with JReleaser deploy
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rpc/archive.gradle | Switched repository URL to local staging-deploy and removed manual signing block |
| ledger/archive.gradle | Removed signing plugin and manual Sonatype URLs in favor of local staging directory |
| common/archive.gradle | Same as above: local staging, drop manual signing |
| client/archive.gradle | Same as above: local staging, drop manual signing |
| gradle/wrapper/gradle-wrapper.properties | Bumped Gradle wrapper distribution URL to 7.6.6 |
| .github/workflows/release.yaml | Replaced manual OSSRH publish with jreleaserDeploy and new JReleaser environment variables |
| .github/workflows/release-snapshot.yaml | Same as above for snapshot workflow |
Comments suppressed due to low confidence (3)
gradle/wrapper/gradle-wrapper.properties:3
- [nitpick] Consider updating the project CHANGELOG or release notes to document the Gradle wrapper bump to version 7.6.6.
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.6-bin.zip
.github/workflows/release.yaml:36
- [nitpick] Running
publishwithout a precedingcleanmay include stale outputs; consider using./gradlew clean publish.
run: ./gradlew publish
.github/workflows/release-snapshot.yaml:34
- [nitpick] Similarly here, adding
cleanbeforepublish(e.g.,./gradlew clean publish) can prevent lingering artifacts from previous runs.
run: ./gradlew publish
brfrn169
left a comment
brfrn169
left a comment
There was a problem hiding this comment.
Left a few comments. Please take a look when you have time!
feeblefakie
left a comment
feeblefakie
left a comment
There was a problem hiding this comment.
Overall, looking good. Left one question. PTAL!
|
@choplin @kota2and3kan I will merge this for testing, but PTAL when you get a chance. |
3 participants
Description
This PR configures Jreleaser to release artifacts in the new Maven Central.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
See inline comments for details.