Skip to content

Conversation

@jnmt
Copy link
Collaborator

@jnmt jnmt commented Oct 6, 2025

Description

This PR updates the scheduled vulnerability check and Dependabot configuration for v3.12.

Related issues and/or PRs

N/A

Changes made

  • Updates the scheduled vulnerability check and Dependabot configuration for v3.12.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Since the reviewer feature in Dependabot is no longer supported, I also removed the related configurations in the PR. I will introduce a GitHub action to add reviewers in another PR based on scalar-labs/scalardb#2694, as the CODEOWNERS feature is not suitable for our situation.

Copilot AI review requested due to automatic review settings October 6, 2025 04:51
@jnmt jnmt self-assigned this Oct 6, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the vulnerability checking and dependency management configuration to include support for version 3.12. It adds a new scheduled vulnerability check job for the v3.12 branch and creates a corresponding Dependabot configuration entry for GitHub Actions updates on that branch, while also removing reviewer assignments from all existing Dependabot configurations.

  • Adds scheduled vulnerability checking for v3.12 branch
  • Configures Dependabot to monitor GitHub Actions updates for v3.12 branch
  • Removes reviewer assignments from all Dependabot update configurations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/scheduled-vuln-check.yaml Adds new vulnerability check job for v3.12 branch
.github/dependabot.yml Adds v3.12 GitHub Actions monitoring and removes all reviewer assignments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gemini-code-assist
Copy link

Summary of Changes

Hello @jnmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's dependency management strategy by updating the Dependabot configuration. It removes redundant automatic reviewer assignments across several package ecosystems and introduces a dedicated configuration for GitHub Actions on the v3.12 branch, ensuring consistent and automated vulnerability checks and dependency updates for this specific version.

Highlights

  • Dependabot Reviewer Removal: The automatic assignment of scalar-labs/scalardl as reviewers has been removed from all existing Dependabot configurations for various package ecosystems (Java Gradle, Docker, and GitHub Actions for branches 3, 3.11, 3.10, and 3.9).
  • New Dependabot Configuration for v3.12: A new Dependabot configuration has been added specifically for github-actions targeting the 3.12 branch, including a new groups definition to manage these actions.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/scheduled-vuln-check.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jnmt jnmt added improvement github_actions Pull requests that update GitHub Actions code labels Oct 6, 2025
@jnmt jnmt requested review from choplin and feeblefakie October 6, 2025 04:52
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dependabot configuration by removing the reviewers field from all entries and adding support for GitHub Actions on the 3.12 branch. My review focuses on two main points. First, the removal of reviewers could lead to unassigned Dependabot PRs, potentially causing security updates to be missed. It's crucial to have an alternative review assignment mechanism. Second, the new configuration for github-actions introduces the groups feature, which is a good practice, but it's applied inconsistently as other github-actions entries lack it. This could affect maintainability.

Copy link

@choplin choplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 14d0d3e into master Oct 7, 2025
10 checks passed
@feeblefakie feeblefakie deleted the update-vuln-check-and-dependabot-config-for-v3.12 branch October 7, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants