-
Notifications
You must be signed in to change notification settings - Fork 3
Update scheduled vulnerability check and Dependabot configuration #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scheduled vulnerability check and Dependabot configuration #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the vulnerability checking and dependency management configuration to include support for version 3.12. It adds a new scheduled vulnerability check job for the v3.12 branch and creates a corresponding Dependabot configuration entry for GitHub Actions updates on that branch, while also removing reviewer assignments from all existing Dependabot configurations.
- Adds scheduled vulnerability checking for v3.12 branch
- Configures Dependabot to monitor GitHub Actions updates for v3.12 branch
- Removes reviewer assignments from all Dependabot update configurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/scheduled-vuln-check.yaml | Adds new vulnerability check job for v3.12 branch |
| .github/dependabot.yml | Adds v3.12 GitHub Actions monitoring and removes all reviewer assignments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary of ChangesHello @jnmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's dependency management strategy by updating the Dependabot configuration. It removes redundant automatic reviewer assignments across several package ecosystems and introduces a dedicated configuration for GitHub Actions on the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Dependabot configuration by removing the reviewers field from all entries and adding support for GitHub Actions on the 3.12 branch. My review focuses on two main points. First, the removal of reviewers could lead to unassigned Dependabot PRs, potentially causing security updates to be missed. It's crucial to have an alternative review assignment mechanism. Second, the new configuration for github-actions introduces the groups feature, which is a good practice, but it's applied inconsistently as other github-actions entries lack it. This could affect maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR updates the scheduled vulnerability check and Dependabot configuration for v3.12.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
Since the reviewer feature in Dependabot is no longer supported, I also removed the related configurations in the PR. I will introduce a GitHub action to add reviewers in another PR based on scalar-labs/scalardb#2694, as the
CODEOWNERSfeature is not suitable for our situation.