Add release workflows #71
Conversation
| - "[0-9]+" | ||
| - "[0-9]+.[0-9]+" |
There was a problem hiding this comment.
We will release SNAPSHOT versions of release and support branches to properly refer them from each release and support branches from the scalar repository.
| mavenJava(MavenPublication) { | ||
| artifactId = 'scalardl-ledger' |
There was a problem hiding this comment.
@feeblefakie Not sure, but do we need to do something to release a new artifact in Maven?
There was a problem hiding this comment.
I don't think so, but we'll see...
| docker push ghcr.io/scalar-labs/scalardl-ledger:${{ steps.version.outputs.version }} | ||
| docker push ghcr.io/scalar-labs/scalardl-client:${{ steps.version.outputs.version }} |
There was a problem hiding this comment.
We will release Docker images of the community edition with the new name "scalardl-xx" while keeping the old ones until we can confirm they are no longer referred.
BTW, do we really need to release the client image? Let me know your opinion or use cases if you know.
There was a problem hiding this comment.
BTW, do we really need to release the client image? Let me know your opinion or use cases if you know.
At least, I think we are using ghcr.io/scalar-labs/scalar-client in scalardl-samples.
https://github.com/scalar-labs/scalardl-samples/blob/v3.10.0/docker-compose-auditor.yml#L23
However, the scalar-client is already public. So, I think we need to discuss which we should use scalar-client or salardl-client in the scalardl-samples. Let's discuss it tomorrow meeting!
There was a problem hiding this comment.
Ah, sorry. I misunderstood. It's a SNAPSHOT image.
I think we don't use the scalar-client of the SNAPSHOT version anywhere.
If it includes ScalarDL CLI, some users or developers might want to use it for the testing of the main branch. But, I don't come up with some concrete use cases other than that, at the moment.
| mavenJava(MavenPublication) { | ||
| artifactId = 'scalardl-ledger' |
There was a problem hiding this comment.
I don't think so, but we'll see...
| docker push ghcr.io/scalar-labs/scalardl-ledger:${{ steps.version.outputs.version }} | ||
| docker push ghcr.io/scalar-labs/scalardl-client:${{ steps.version.outputs.version }} |
There was a problem hiding this comment.
BTW, do we really need to release the client image? Let me know your opinion or use cases if you know.
At least, I think we are using ghcr.io/scalar-labs/scalar-client in scalardl-samples.
https://github.com/scalar-labs/scalardl-samples/blob/v3.10.0/docker-compose-auditor.yml#L23
However, the scalar-client is already public. So, I think we need to discuss which we should use scalar-client or salardl-client in the scalardl-samples. Let's discuss it tomorrow meeting!
| docker push ghcr.io/scalar-labs/scalardl-ledger:${{ steps.version.outputs.version }} | ||
| docker push ghcr.io/scalar-labs/scalardl-client:${{ steps.version.outputs.version }} |
There was a problem hiding this comment.
Ah, sorry. I misunderstood. It's a SNAPSHOT image.
I think we don't use the scalar-client of the SNAPSHOT version anywhere.
If it includes ScalarDL CLI, some users or developers might want to use it for the testing of the main branch. But, I don't come up with some concrete use cases other than that, at the moment.
3 participants
Description
This PR adds release workflows for ScalarDL Ledger.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A