Skip to content

Fix releasing snapshot container images #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

Fix releasing snapshot container images #96

merged 1 commit into from
Mar 17, 2025
+7 −0

Conversation

@jnmt
Copy link
Collaborator

@jnmt jnmt commented Mar 6, 2025

Description

This PR includes a fix to release snapshot container images. It failed because I probably forgot to add the login step.

Related issues and/or PRs

Changes made

  • Add the login settings for ghcr.io

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@jnmt jnmt added the bugfix label Mar 6, 2025
@jnmt jnmt requested review from choplin and feeblefakie March 6, 2025 06:34
@jnmt jnmt self-assigned this Mar 6, 2025
feeblefakie
feeblefakie approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

choplin
choplin approved these changes Mar 17, 2025
View reviewed changes
Copy link

@choplin choplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jnmt jnmt merged commit 18a8bf4 into master Mar 17, 2025
5 checks passed
@jnmt jnmt deleted the fix-snapshot-container-release branch March 17, 2025 04:54
jnmt added a commit that referenced this pull request Mar 17, 2025
@jnmt
Fix releasing snapshot container images (#96)
b473e78
jnmt added a commit that referenced this pull request Mar 17, 2025
@jnmt
Fix releasing snapshot container images (#96)
886d8de
This was referenced Mar 17, 2025
Merged
Merged
jnmt added a commit that referenced this pull request Mar 17, 2025
@jnmt
Fix releasing snapshot container images (#96)
7e1cd27
@jnmt jnmt mentioned this pull request Mar 17, 2025
Merged
jnmt added a commit that referenced this pull request Mar 17, 2025
@jnmt
Fix releasing snapshot container images (#96)
ea43f73
@jnmt jnmt mentioned this pull request Mar 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@choplin choplin choplin approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@jnmt jnmt

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnmt @choplin @feeblefakie