Merged
Conversation
yixu34
approved these changes
Jul 6, 2023
| readiness_initial_delay_seconds: int, | ||
| triton_model_repository: str, | ||
| triton_model_replicas: Optional[Dict[str, str]], | ||
| triton_model_replicas: Optional[Dict[str, str]] = None, |
Member
There was a problem hiding this comment.
Huh I take it we don't have any prior such bundles then? Otherwise I'm guessing people would have run into this.
Contributor
There was a problem hiding this comment.
Folks have had to explicitly set triton_model_replicas since this specific bundle flavor was introduced.
| readiness_initial_delay_seconds: int, | ||
| triton_model_repository: str, | ||
| triton_model_replicas: Optional[Dict[str, str]], | ||
| triton_model_replicas: Optional[Dict[str, str]] = None, |
Contributor
There was a problem hiding this comment.
route changes look good
@malcolmgreaves can you double confirm the triton ones?
Contributor
There was a problem hiding this comment.
LGTM! Thanks for @-ing me here
malcolmgreaves
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They're not actually optional rn oops 😅