add better support for overwriting endpoint#125
Merged
edwardpark97 merged 3 commits intomasterfrom Jul 17, 2023
Merged
Conversation
added 2 commits
July 12, 2023 16:58
yixu34
reviewed
Jul 12, 2023
launch/constants.py
Outdated
| SCALE_LAUNCH_ENDPOINT = "https://api.scale.com/v1/hosted_inference" | ||
| SCALE_LAUNCH_V1_ENDPOINT = "https://api.scale.com/v1/launch" | ||
| DEFAULT_SCALE_ENDPOINT = "https://api.scale.com" | ||
| HOSTED_INFERENCE_PATH = "/v1/hosted_inference" |
Member
There was a problem hiding this comment.
In the spirit of the previous names, maybe let's call this SCALE_LAUNCH_V0_PATH and SCALE_LAUNCH_V1_PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feeding in your own endpoint to the Launch client didn't work very well because some of the calls go to
/v1/hosted_inferenceand other calls go to/v1/launchand the old behavior rewrote both