Skip to content

Support path extensions when using custom endpoints #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaisanliang merged 2 commits into from
Nov 2, 2023
Merged

Support path extensions when using custom endpoints #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aa868d
Support path extensions when using custom endpoints
jaisanliang Nov 1, 2023
72929ed
Fix line too long lint
jaisanliang Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion launch/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ def __init__(
api_key: str,
endpoint: Optional[str] = None,
self_hosted: bool = False,
use_path_with_custom_endpoint: bool = False,
):
"""
Initializes a Scale Launch Client.
Expand All @@ -262,6 +263,8 @@ def __init__(
api_key: Your Scale API key
endpoint: The Scale Launch Endpoint (this should not need to be changed)
self_hosted: True iff you are connecting to a self-hosted Scale Launch
use_path_with_custom_endpoint: True iff you are not using the default Scale Launch endpoint
but your endpoint has path routing (to SCALE_LAUNCH_VX_PATH) set up
"""
self.endpoint = endpoint or DEFAULT_SCALE_ENDPOINT
self.connection = Connection(api_key, self.endpoint + SCALE_LAUNCH_V0_PATH)
Expand All @@ -270,8 +273,11 @@ def __init__(
self.upload_batch_csv_fn: Optional[Callable[[str, str], None]] = None
self.bundle_location_fn: Optional[Callable[[], str]] = None
self.batch_csv_location_fn: Optional[Callable[[], str]] = None
host = self.endpoint + SCALE_LAUNCH_V1_PATH if endpoint is None else self.endpoint
if use_path_with_custom_endpoint:
host = self.endpoint + SCALE_LAUNCH_V1_PATH
self.configuration = Configuration(
host=self.endpoint + SCALE_LAUNCH_V1_PATH if endpoint is None else self.endpoint,
host=host,
discard_unknown_keys=True,
username=api_key,
password="",
Expand Down