Wrappers around autogen client for docker image batch jobs#93
Merged
seanshi-scale merged 8 commits intomasterfrom May 3, 2023
Merged
Wrappers around autogen client for docker image batch jobs#93seanshi-scale merged 8 commits intomasterfrom
seanshi-scale merged 8 commits intomasterfrom
Conversation
phil-scale
approved these changes
May 3, 2023
Contributor
phil-scale
left a comment
phil-scale
left a comment
There was a problem hiding this comment.
I've officially fallen out of love with openapi autogenerated clients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch job bundles return dtos, batch jobs return raw json (can change if we want but the og batch job client methods return raw json)
Basically just wrappers around the existing autogen classes + some dto response objects