Fix integration tests for streaming case #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmchoiboi
force-pushed
the
dmchoi/fix-integration-tests
branch
from
2793e48 to
6468b23
Compare
integration_tests/rest_api_utils.py
Outdated
| required_output_fields: Optional[List[str]], | ||
| response_text_regex: Optional[str], | ||
| ): | ||
| print("raw response", response) |
Collaborator
Author
There was a problem hiding this comment.
we can; it's been helpful for debugging if the tests fail
yunfeng-scale
approved these changes
Jun 24, 2024
| ) as response: | ||
| assert response.status == 200, (await response.read()).decode() | ||
| return await response.json() | ||
| return (await response.read()).decode() |
Contributor
There was a problem hiding this comment.
hmm, how did this work before?
Collaborator
Author
There was a problem hiding this comment.
i'm pretty sure it didn't
integration_tests/rest_api_utils.py
Outdated
Comment on lines
1004
to
1007
Contributor
There was a problem hiding this comment.
should implement these?
Collaborator
Author
There was a problem hiding this comment.
i'm not really sure what this is supposed to be testing. the response for streaming is different from that for sync so the same checks don't really apply
dmchoiboi
force-pushed
the
dmchoi/fix-integration-tests
branch
from
44f30ca to
861fea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.
vLLM integration tests for the stream case has a few bugs that this addresses
Test Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.