Skip to content

Conversation

@TarunRavikumar
Copy link
Contributor

Problem

PR #713 (commit da85235) refactored FORWARDER_EXTRA_ROUTES into FORWARDER_SYNC_ROUTES and FORWARDER_STREAMING_ROUTES in the Python code, but forgot to update the Helm deployment templates. The templates never passed these new variables to the forwarder container via --set flags. This broke mcpx-go's /mcp route — the route was being constructed in Python but never injected into the forwarder container's configuration.

Fix

Updated service_template_config_map.yaml to add --set flags for:

  • forwarder.sync.routes=${FORWARDER_SYNC_ROUTES}
  • forwarder.stream.routes=${FORWARDER_STREAMING_ROUTES}

This properly configures the forwarder to register custom routes (like /mcp) that are specified in the extra_routes field.

Files Changed

  • charts/model-engine/templates/service_template_config_map.yaml (4 locations: sync mode, streaming mode, LeaderWorkerSet sync, LeaderWorkerSet streaming)

@TarunRavikumar TarunRavikumar changed the title Pass FORWARDER_SYNC_ROUTES and FORWARDER_STREAMING_ROUTES to forwarder container [PSP-487] Pass FORWARDER_SYNC_ROUTES and FORWARDER_STREAMING_ROUTES to forwarder container Nov 10, 2025
@TarunRavikumar TarunRavikumar marked this pull request as ready for review November 10, 2025 15:16
@TarunRavikumar TarunRavikumar merged commit 94ad7f6 into main Nov 10, 2025
7 checks passed
@TarunRavikumar TarunRavikumar deleted the tr/fix branch November 10, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants