fix(model-engine): remediate Trivy vulnerability findings#818
Merged
scale-ballen merged 7 commits intomainfrom May 7, 2026
Merged
fix(model-engine): remediate Trivy vulnerability findings#818scale-ballen merged 7 commits intomainfrom
scale-ballen merged 7 commits intomainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
lilyz-ai
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Trivy Result
Greptile Summary
transformers>=5.0.0), rebuildingkubectlat v1.35.4 andaws-iam-authenticatorat v0.7.15 from source, and uninstallingpipfrom the runtime venv to eliminate pip CVEs from scan results.SPIECE_UNDERLINEis now defined locally inpostprocessing/model.py, and thelive_tokenizer_repository.pyHF-repo lookup is refactored from a raise-and-catch pattern to a cleanerif/else.aws-iam-authenticatorGo build omitsGOTOOLCHAIN=localthat thekubectlbuild uses, which could allow auto-downloading a newer toolchain in restricted network environments.Confidence Score: 5/5
Safe to merge; all changes are security-motivated version bumps with verified smoke-test passage and only one minor P2 style inconsistency.
Only P2 findings — the missing
GOTOOLCHAIN=localon the aws-iam-authenticator build — with no P0/P1 issues. The logic changes inlive_tokenizer_repository.pyare functionally equivalent refactors, theSPIECE_UNDERLINEconstant is stable, and the dependency upgrades are all security-driven with passing smoke tests per the PR description.No files require special attention; the Dockerfile
aws-iam-authenticatorbuild step has a minor consistency note.Important Files Changed
go installtogit clone + go buildat v0.7.15; the authenticator build omitsGOTOOLCHAIN=localunlike the kubectl build.SPIECE_UNDERLINEimport from transformers (removed in v5.x) and defines the constant locally as"\u2581"— correct value, safe change.if/elseinstead of raise-and-catchRepositoryNotFoundError; functionally equivalent but cleaner.Prompt To Fix All With AI
Reviews (7): Last reviewed commit: "fix(model-engine): clear remaining trivy..." | Re-trigger Greptile