-
Notifications
You must be signed in to change notification settings - Fork 0
Expose HEALTH_CHECK_PORT as an env var #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR exposes the health check port for Temporal workers as an environment variable HEALTH_CHECK_PORT to make it configurable through agent configurations.
- Added
health_check_portfield toTemporalConfigclass with default value of None - Introduced
HEALTH_CHECK_PORTenvironment variable with default value of 80 - Updated worker initialization to read health check port from environment variable instead of hardcoded value
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/agentex/lib/types/agent_configs.py | Added health_check_port field to TemporalConfig |
| src/agentex/lib/environment_variables.py | Added HEALTH_CHECK_PORT environment variable definition |
| src/agentex/lib/core/temporal/workers/worker.py | Updated worker to read health check port from environment |
| src/agentex/lib/cli/templates/temporal/manifest.yaml.j2 | Added commented configuration example for health_check_port |
| src/agentex/lib/cli/handlers/run_handlers.py | Added logic to set HEALTH_CHECK_PORT from temporal config |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.