-
Notifications
You must be signed in to change notification settings - Fork 0
[Chore] Remove Rye. Fully migrate to UV #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
| run: | | ||
| if [ "${{ inputs.uv-version }}" = "latest" ]; then | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| else | ||
| curl -LsSf https://astral.sh/uv/${{ inputs.uv-version }}/install.sh | sh | ||
| fi | ||
| echo "$HOME/.local/bin" >> $GITHUB_PATH | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue in your code:
Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by run-shell-injection.
You can view more details about this finding in the Semgrep AppSec Platform.
Summary
Complete migration from Rye to UV package management with streamlined development workflow and CI/CD modernization.
Changes
Package Management:
GitHub Workflows:
Development Workflow:
Key Commands:
Breaking Changes
Developers need to:
Complex scripts (scripts/test, scripts/mock) preserved unchanged.