Skip to content

Conversation

@prassanna-ravishankar
Copy link
Member

@prassanna-ravishankar prassanna-ravishankar commented Oct 3, 2025

env vars dont get populated by the manifest and the value is only available using EnvironmentVariables.refresh().

Current code errors on missing value in manifest

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes health check port handling in the Temporal worker by addressing an issue where environment variables are not populated from the manifest, causing errors when trying to access the HEALTH_CHECK_PORT environment variable directly.

  • Changes the parameter type from int to int | None to allow optional health check port
  • Implements fallback logic using EnvironmentVariables.refresh() when port is not provided

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@prassanna-ravishankar prassanna-ravishankar marked this pull request as ready for review October 3, 2025 15:10
@prassanna-ravishankar prassanna-ravishankar enabled auto-merge (squash) October 3, 2025 15:18
@prassanna-ravishankar prassanna-ravishankar merged commit fe22301 into main Oct 3, 2025
10 checks passed
@prassanna-ravishankar prassanna-ravishankar deleted the fix/health-check-port-handling branch October 3, 2025 15:32
@stainless-app stainless-app bot mentioned this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants