Skip to content

Conversation

@prassanna-ravishankar
Copy link
Member

#99 didn't cover temporal async agents

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends header forwarding support to temporal async agents by ensuring request headers are properly passed through the temporal ACP implementation chain. The fix addresses a gap where PR #99 implemented header forwarding for synchronous agents but missed the temporal workflow path.

  • Adds request parameter forwarding in the temporal ACP event handler
  • Updates TemporalTaskService.send_event method to accept and forward request headers
  • Includes comprehensive test coverage for temporal header forwarding scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/agentex/lib/sdk/fastacp/impl/temporal_acp.py Passes request parameter to temporal task service event handler
src/agentex/lib/core/temporal/services/temporal_task_service.py Adds request parameter to send_event method signature and forwards it to temporal signal payload
tests/test_header_forwarding.py Adds comprehensive test suite for temporal ACP header forwarding functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@prassanna-ravishankar prassanna-ravishankar marked this pull request as ready for review October 6, 2025 19:19
@prassanna-ravishankar prassanna-ravishankar merged commit 67cb3ff into main Oct 17, 2025
10 checks passed
@prassanna-ravishankar prassanna-ravishankar deleted the fix/header-forwarding-temporal branch October 17, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants