Skip to content

[Auth] Fix #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 29, 2025
Merged

[Auth] Fix #38

merged 7 commits into from
Jul 29, 2025

Conversation

@anishxyz
Copy link
Contributor

@anishxyz anishxyz commented Jul 29, 2025

No description provided.

@smoreinis
Copy link
Contributor

smoreinis commented Jul 29, 2025

I checked out this branch and I'm still getting an error, now on refreshed_environment_variables.AGENT_ID = agent_id in base_acp_server when I run the 000_hello_acp agent locally.

@smoreinis smoreinis self-requested a review July 29, 2025 01:46
smoreinis
smoreinis approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@smoreinis smoreinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me locally now

@anishxyz anishxyz merged commit b56eab2 into main Jul 29, 2025
7 of 8 checks passed
@anishxyz anishxyz deleted the anishxyz/authn branch July 29, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoreinis smoreinis smoreinis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anishxyz @smoreinis