Skip to content

chore(authz): scrub internal project references from comments and docstrings#268

Merged
asherfink merged 1 commit into
mainfrom
asher.fink/scrub-authz-comment-refs
Jun 3, 2026
Merged

chore(authz): scrub internal project references from comments and docstrings#268
asherfink merged 1 commit into
mainfrom
asher.fink/scrub-authz-comment-refs

Conversation

@asherfink
Copy link
Copy Markdown
Contributor

@asherfink asherfink commented Jun 2, 2026

Scrubs internal references (Linear ticket IDs, internal service names, internal flag names) from comments and docstrings across already-landed authorization code. Fixes issues introduced by #248, #252, #255, #257, #259, and #260.

No behavior changes.

Greptile Summary

This PR scrubs internal project references — Linear ticket IDs, internal service names (SpiceDB, Spark, agentex-auth, spark-authz), and internal flag identifiers — from comments and docstrings across authorization code landed in PRs #248#260. There are zero behavior changes.

  • Comments/docstrings only: Every diff hunk is a text-only change; no imports, logic, call sites, or test assertions are touched.
  • Terminology generalized: Internal names like "SpiceDB" and "Spark AuthZ" are replaced with generic terms (authorization schema, authorization service, authorization cascade) that remain accurate without leaking implementation details.
  • TODO tickets removed: Two TODO(AGX1-290): markers are simplified to bare TODO: comments, preserving the intent while dropping the internal tracker reference.

Confidence Score: 5/5

Safe to merge — every change is comment or docstring text only with no effect on runtime behavior.

All twelve files receive purely textual edits to comments and docstrings. No logic, imports, call sites, or test assertions are modified, so there is no risk of a behavioral regression.

No files require special attention.

Important Files Changed

Filename Overview
agentex/src/adapters/authorization/port.py Replaced 'SpiceDB' with 'authorization schema' in two docstring phrases — no logic changes.
agentex/src/api/routes/agent_api_keys.py Scrubbed 'SpiceDB' from two inline comments; logic and call sites unchanged.
agentex/src/domain/services/authorization_service.py Single docstring word swap ('SpiceDB schema' → 'authorization schema') — no logic changes.
agentex/src/domain/use_cases/agent_api_keys_use_case.py Removed unconditional-routing comment, replaced 'agentex-auth' and 'FGAC' references with generic names — no logic changes.
agentex/src/utils/agent_api_key_authorization.py Removed Linear ticket ID from TODO comment, preserving the intent — no logic changes.
agentex/src/utils/agent_authorization.py Removed Linear ticket ID from TODO comment, preserving the intent — no logic changes.
agentex/tests/integration/api/checkpoints/test_checkpoints_authz_api.py Removed Linear ticket references and 'SpiceDB' from module docstring — tests and assertions unchanged.
agentex/tests/integration/api/events/test_events_authz_api.py Module docstring updated to remove Linear ticket ID; no test logic changes.
agentex/tests/integration/api/messages/test_messages_authz_api.py Module docstring updated to remove Linear ticket reference; no test logic changes.
agentex/tests/integration/services/test_agent_api_key_service_dual_write.py Replaced 'Spark AuthZ', 'agentex-auth', 'SpiceDB', and Linear ticket IDs throughout docstrings and inline comments — tests and assertions unchanged.
agentex/tests/integration/services/test_schedule_service_dual_write.py Replaced 'Spark AuthZ', 'SpiceDB', and internal service names throughout docstrings — tests and assertions unchanged.
agentex/tests/unit/api/test_agent_api_keys_authz.py Module docstring scrubbed of Linear ticket ID and 'Spark AuthZ' references — no test logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR #268 – comment scrub] --> B[Source files\nagentex/src/]
    A --> C[Test files\nagentex/tests/]
    B --> D[adapters/authorization/port.py\nSpiceDB → authorization schema]
    B --> E[api/routes/agent_api_keys.py\nSpiceDB → authorization service]
    B --> F[domain/services/authorization_service.py\nSpiceDB schema → authorization schema]
    B --> G[domain/use_cases/agent_api_keys_use_case.py\nRemove internal routing comment]
    B --> H[utils/agent_api_key_authorization.py\nTODO ticket ID removed]
    B --> I[utils/agent_authorization.py\nTODO ticket ID removed]
    C --> J[integration/api – 3 files\nLinear IDs + SpiceDB removed from docstrings]
    C --> K[integration/services – 2 files\nSpark AuthZ → authorization service]
    C --> L[unit/api – 1 file\nModule docstring scrubbed]
Loading

Reviews (3): Last reviewed commit: "chore(authz): scrub internal project ref..." | Re-trigger Greptile

@asherfink asherfink force-pushed the asher.fink/scrub-authz-comment-refs branch from d22656c to a41c31e Compare June 2, 2026 21:43
@asherfink asherfink marked this pull request as ready for review June 2, 2026 21:43
@asherfink asherfink requested a review from a team as a code owner June 2, 2026 21:43
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this comment since it refers to agentex-auth

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can refine this comment since it refers to agentex-auth and Spark

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@asherfink asherfink force-pushed the asher.fink/scrub-authz-comment-refs branch from a41c31e to 62581f7 Compare June 2, 2026 22:09
@asherfink asherfink force-pushed the asher.fink/scrub-authz-comment-refs branch from 62581f7 to 628e8fb Compare June 3, 2026 14:52
@asherfink asherfink enabled auto-merge (squash) June 3, 2026 14:52
@asherfink asherfink merged commit 8b6d69d into main Jun 3, 2026
29 checks passed
@asherfink asherfink deleted the asher.fink/scrub-authz-comment-refs branch June 3, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants