Skip to content

use switchOnFirst replacing HeadAndTail #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 1, 2019
Merged

use switchOnFirst replacing HeadAndTail #510

merged 23 commits into from
Mar 1, 2019

Conversation

@ronenhamias
Copy link
Member

@ronenhamias ronenhamias commented Jan 25, 2019 •
edited
Loading

#509

  1. update version 3.2.5.RELEASE
  2. refactor and use switchOnFirst.

segabriel
segabriel reviewed Jan 25, 2019
View reviewed changes
services/src/test/java/io/scalecube/services/ServiceRemoteTest.java Outdated
StepVerifier.create(responses)
.expectErrorMessage("IllegalArgumentException")
.verify(Duration.ofSeconds(3));
.verify(Duration.ofSeconds(300));
Copy link
Member

@segabriel segabriel Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really needed?

Copy link
Member Author

@ronenhamias ronenhamias Jan 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we need it but lets keep it 3 and not 300
it appear to be a bug in reactor so lets just wait until its fixed.

https://github.com/reactor/reactor-core/pull/1493/files

Copy link
Member Author

@ronenhamias ronenhamias Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rsocket/rsocket-java#579

@ronenhamias ronenhamias changed the title update version 3.2.5.RELEASE use switchOnFirst replacing HeadAndTail Jan 25, 2019
@ronenhamias ronenhamias mentioned this pull request Jan 25, 2019
Closed
@segabriel
Copy link
Member

segabriel commented Feb 13, 2019

I see we use netty version 4.1.31.Final at that time reactor-netty uses 4.1.33.Final, we should consider how to resolve this problem.

@artem-v artem-v merged commit ce01a81 into develop Mar 1, 2019
@artem-v artem-v deleted the use_switch_on_first branch March 1, 2019 16:00
@artem-v artem-v mentioned this pull request Mar 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@segabriel segabriel segabriel left review comments

@artem-v artem-v artem-v approved these changes

@OlegDokuka OlegDokuka Awaiting requested review from OlegDokuka

@dmytro-lazebnyi dmytro-lazebnyi Awaiting requested review from dmytro-lazebnyi

Assignees

No one assigned

Labels

discussion 💬 Improvement ↗️

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronenhamias @segabriel @artem-v @OlegDokuka @dmytro-lazebnyi