Skip to content

Conversation

contextablemark
Copy link
Contributor

Addresses: #93

Changes

  • Updated pydantic dependency constraint from ~2.10.6 to ~2.11.2 in setup.py
  • Updated pydantic dependency constraint from ~2.10.6 to ~2.11.2 in requirements.txt

Compatibility Testing Performed

Comprehensive testing was conducted to ensure no breaking changes affect the SDK:

Tested Pydantic 2.11.2 Breaking Changes

  1. model_fields/model_computed_fields attributes: Not used in SDK codebase
  2. Core schema generation logic: No custom schema handling found
  3. create_model field format: No create_model usage found
  4. Internal metadata type strictness: No custom metadata handling found

Verified Working Features

  • model_dump() method: Tested in CreateConnectedAccountResponse.to_dict() and GetConnectedAccountAuthResponse.to_dict()
  • field_validator decorators: Tested validation logic in ToolRequest model
  • Config classes: validate_assignment and json_encoders still work
  • Standard pydantic models: All core models (ToolMapping, CreateConnectedAccountRequest, ToolRequest) function correctly
  • SDK imports: All modules import successfully
  • Field validation: Optional fields, type checking, custom validation rules working
  • Model instantiation: All tested models create and validate correctly

Testing Notes

  • No compatibility issues detected during local testing with pydantic 2.11.9
  • All existing pydantic functionality continues to work
  • No breaking changes impact the SDK codebase
  • Upgrade constraint allows pydantic 2.11.x versions to be installed

🤖 Generated with Claude Code

Addresses: scalekit-inc#93

## Changes
- Updated pydantic dependency constraint from ~2.10.6 to ~2.11.2 in setup.py
- Updated pydantic dependency constraint from ~2.10.6 to ~2.11.2 in requirements.txt

## Compatibility Testing Performed
Comprehensive testing was conducted to ensure no breaking changes affect the SDK:

### Tested Pydantic 2.11.2 Breaking Changes
1. ✅ **model_fields/model_computed_fields attributes**: Not used in SDK codebase
2. ✅ **Core schema generation logic**: No custom schema handling found
3. ✅ **create_model field format**: No create_model usage found
4. ✅ **Internal metadata type strictness**: No custom metadata handling found

### Verified Working Features
- ✅ **model_dump() method**: Tested in CreateConnectedAccountResponse.to_dict() and GetConnectedAccountAuthResponse.to_dict()
- ✅ **field_validator decorators**: Tested validation logic in ToolRequest model
- ✅ **Config classes**: validate_assignment and json_encoders still work
- ✅ **Standard pydantic models**: All core models (ToolMapping, CreateConnectedAccountRequest, ToolRequest) function correctly
- ✅ **SDK imports**: All modules import successfully
- ✅ **Field validation**: Optional fields, type checking, custom validation rules working
- ✅ **Model instantiation**: All tested models create and validate correctly

## Testing Notes
- No compatibility issues detected during local testing with pydantic 2.11.9
- All existing pydantic functionality continues to work
- No breaking changes impact the SDK codebase
- Upgrade constraint allows pydantic 2.11.x versions to be installed

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Collaborator

@jranaskit jranaskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for insight and raising this, approving this PR to upgrade pydantic version.

@dhaneshbs dhaneshbs merged commit 11e0e50 into scalekit-inc:main Sep 16, 2025
@contextablemark contextablemark deleted the feat/upgrade-pydantic-2.11.2 branch September 16, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants