fix: Add zone parameter to scaleway_instance_private_nic data source for multi-zone deployments #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scaleway_instance_private_nic data source was missing the zone parameter, which could cause issues when deploying instances across multiple zones. This fix ensures the private NIC data source uses the same zone as the instance.
Add example demonstrating how to deploy instances across multiple zones. This example showcases the fixed scaleway_instance_private_nic data source that now properly includes the zone parameter for multi-zone deployments.
Signed-off-by: marc <marc@agorapulse.com>
Signed-off-by: marc <marc@agorapulse.com>
Signed-off-by: marc <marc@agorapulse.com>
Updated the README to reflect changes in instance configuration and security group naming. Signed-off-by: marc <marc@agorapulse.com>
Signed-off-by: marc <marc@agorapulse.com>
benoit-garcia
requested changes
Sep 4, 2025
Member
benoit-garcia
left a comment
benoit-garcia
left a comment
There was a problem hiding this comment.
Thanks for your contribution @maathor !
There's a small error in the example's readme file. Can you fix it before merging?
Co-authored-by: Benoit Garcia <72207524+benoit-garcia@users.noreply.github.com> Signed-off-by: marc <marc@agorapulse.com>
benoit-garcia
approved these changes
Sep 5, 2025
benoit-garcia
merged commit 6944441
into
scaleway-terraform-modules:main
5 checks passed
benoit-garcia
added
bug
Member
|
@maathor Approved, merged and released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the
scaleway_instance_private_nicdata source was missing thezoneparameter, which could cause problems when deploying instances across multiple availability zones.Changes
zone = var.zoneparameter to thescaleway_instance_private_nicdata source inipv4.tfexamples/multi-zones/demonstrating multi-zone instance deploymentProblem
When deploying instances with private networks across different zones, the
scaleway_instance_private_nicdata source would not specify which zone to query, potentially causing:Solution
The fix ensures the private NIC data source uses the same zone as the instance it belongs to, maintaining consistency across all zone-aware resources in the module.
Testing
The included example in
examples/multi-zones/demonstrates:fr-par-1andfr-par-2)Files Changed
ipv4.tf: Added zone parameter to data sourceexamples/multi-zones/: New example with README, main.tf, and versions.tf