Skip to content

Conversation

@ahamez
Copy link
Contributor

@ahamez ahamez commented Feb 27, 2025

Your checklist for this pull request

Description

  • Make clear that a value is a default value
  • Remove external link that adds no value

The concept has been explained before. Furthermore, it leads to a
Wikipedia page which, in this case, doesn't bring any valuable
information (`syntax` or `version` are not mentioned in this page).
@SamyOubouaziz SamyOubouaziz added the do not merge PR that shouldn't be merged before a specific date (eg release) label Feb 27, 2025
Also, don't list the deprecated value "2012-10-17" as we really don't want
customers to use this value
@SamyOubouaziz SamyOubouaziz merged commit 721efd4 into main Feb 28, 2025
2 of 3 checks passed
@SamyOubouaziz SamyOubouaziz deleted the int-fix-object-storage branch February 28, 2025 13:29
bene2k1 pushed a commit that referenced this pull request Mar 12, 2025
* fix(object-storage): make clear that value is a _default_ value

* fix(object-storage): remove external link that adds no value

The concept has been explained before. Furthermore, it leads to a
Wikipedia page which, in this case, doesn't bring any valuable
information (`syntax` or `version` are not mentioned in this page).

* fix(object-storage): list all possible values for policy version

* fix(object-storage): correct type for Version

Also, don't list the deprecated value "2012-10-17" as we really don't want
customers to use this value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge PR that shouldn't be merged before a specific date (eg release)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants