docs(serverless): clarify ports usage int-fix-serverless #4577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed, we don't specificy what 'different' means here: from a default value?
…and 443 from the internet
bene2k1
reviewed
Mar 10, 2025
bene2k1
approved these changes
Mar 10, 2025
Co-authored-by: Benedikt Rollik <brollik@scaleway.com>
jcirinosclwy
approved these changes
Mar 11, 2025
bene2k1
added a commit
that referenced
this pull request
Mar 12, 2025
* fix(serverless): a port is not related to the HTTP protocol * fix(serverless): add EOL * fix(serverless): remove confusing sentence about different port Indeed, we don't specificy what 'different' means here: from a default value? * feat(serverless): explain that containers are accessible on ports 80 and 443 from the internet * fix(serverless): apply sugession Co-authored-by: Benedikt Rollik <brollik@scaleway.com> --------- Co-authored-by: Benedikt Rollik <brollik@scaleway.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Description
Explain that containers are accessible from ports 80 and 443