Skip to content

feat(vpc): add support for default-route-propagation-enabled #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2025
Merged

feat(vpc): add support for default-route-propagation-enabled #4720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dee1a63
feat: update generated APIs
scaleway-bot May 14, 2025
47dc248
Fix
remyleone May 16, 2025
011647d
Fix
remyleone May 16, 2025
2c2e145
Merge branch 'master' into v1.6527.0
remyleone May 16, 2025
fed5675
Fix
remyleone May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions cmd/scw/testdata/test-all-usage-vpc-private-network-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ USAGE:
scw vpc private-network create [arg=value ...]

ARGS:
name=<generated> Name for the Private Network
[project-id] Project ID to use. If none is passed the default project ID will be used
[tags.{index}] Tags for the Private Network
[subnets.{index}] Private Network subnets CIDR
[vpc-id] VPC in which to create the Private Network
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
name=<generated> Name for the Private Network
[project-id] Project ID to use. If none is passed the default project ID will be used
[tags.{index}] Tags for the Private Network
[subnets.{index}] Private Network subnets CIDR
[vpc-id] VPC in which to create the Private Network
[default-route-propagation-enabled] Defines whether default v4 and v6 routes are propagated for this Private Network
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
-h, --help help for create
Expand Down
9 changes: 5 additions & 4 deletions cmd/scw/testdata/test-all-usage-vpc-private-network-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ USAGE:
scw vpc private-network update <private-network-id ...> [arg=value ...]

ARGS:
private-network-id Private Network ID
[name] Name for the Private Network
[tags.{index}] Tags for the Private Network
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
private-network-id Private Network ID
[name] Name for the Private Network
[tags.{index}] Tags for the Private Network
[default-route-propagation-enabled] Defines whether default v4 and v6 routes are propagated for this Private Network
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
-h, --help help for update
Expand Down
2 changes: 2 additions & 0 deletions docs/commands/vpc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ scw vpc private-network create [arg=value ...]
| tags.{index} | | Tags for the Private Network |
| subnets.{index} | | Private Network subnets CIDR |
| vpc-id | | VPC in which to create the Private Network |
| default-route-propagation-enabled | | Defines whether default v4 and v6 routes are propagated for this Private Network |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down Expand Up @@ -166,6 +167,7 @@ scw vpc private-network update <private-network-id ...> [arg=value ...]
| private-network-id | Required | Private Network ID |
| name | | Name for the Private Network |
| tags.{index} | | Tags for the Private Network |
| default-route-propagation-enabled | | Defines whether default v4 and v6 routes are propagated for this Private Network |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down
14 changes: 14 additions & 0 deletions internal/namespaces/vpc/v2/vpc_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,13 @@ func vpcPrivateNetworkCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "default-route-propagation-enabled",
Short: `Defines whether default v4 and v6 routes are propagated for this Private Network`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down Expand Up @@ -591,6 +598,13 @@ func vpcPrivateNetworkUpdate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "default-route-propagation-enabled",
Short: `Defines whether default v4 and v6 routes are propagated for this Private Network`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down
Loading