Skip to content

Conversation

@Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Oct 28, 2025

This PR starts the migration of tests cassettes from go-vcr (v1.20) to go-vcr.v4 with the instance package. This will be done by gradually making packages use the vcr client from the sdk-go.

The biggest benefit of this change will be to be able to use the SkipRequestLatency option on the recorder that was introduced in v3. This will allow us to replay cassettes a lot faster because interactions will not simulate the requests' duration anymore, therefore making the CI faster.

@Mia-Cross Mia-Cross self-assigned this Oct 28, 2025
@Mia-Cross Mia-Cross added instance Instance issues, bugs and feature requests tests labels Oct 28, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.47%. Comparing base (5060bb1) to head (08f6f61).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
core/testing_recorder.go 0.00% 8 Missing ⚠️
core/testing.go 61.11% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5089      +/-   ##
==========================================
+ Coverage   57.43%   57.47%   +0.03%     
==========================================
  Files         308      308              
  Lines       67126    67151      +25     
==========================================
+ Hits        38552    38593      +41     
+ Misses      27140    27121      -19     
- Partials     1434     1437       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review October 28, 2025 17:35
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners October 28, 2025 17:35
@remyleone remyleone added this pull request to the merge queue Oct 29, 2025
Merged via the queue into scaleway:master with commit 6fd860d Oct 29, 2025
16 checks passed
@Mia-Cross Mia-Cross deleted the bump_go_vcr_v4_instance branch October 29, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants