Skip to content

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Nov 26, 2025

close #3713

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@jremy42 jremy42 requested review from a team and remyleone as code owners November 26, 2025 10:42
@github-actions github-actions bot added the redis Managed Redis issues, bugs and feature requests label Nov 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.40%. Comparing base (d17d4e7) to head (b3bbcf2).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nal/namespaces/redis/v1/custom_version_settings.go 93.02% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
+ Coverage   58.38%   58.40%   +0.02%     
==========================================
  Files         310      311       +1     
  Lines       68250    68294      +44     
==========================================
+ Hits        39848    39889      +41     
- Misses      26920    26922       +2     
- Partials     1482     1483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

List available settings from a Redis™ version.

USAGE:
scw redis version settings [arg=value ...]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list-settings the last one should be a verb

func TestRedisVersionSettingsCommand(t *testing.T) {
t.Parallel()

server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to understand this snippet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

redis Managed Redis issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

redis: allow listing settings

4 participants