Skip to content

feat: remove s3 integration #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2019
Merged

feat: remove s3 integration #573

merged 1 commit into from
Sep 10, 2019

Conversation

@QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Sep 10, 2019 •
edited
Loading

This reverts commit ea013f8.

We advice you to use s3cmd, AWS-CLI or mino.

Arguments:

  • It increases binary sizes from 10Mb.
  • It is not a good implementation.

@QuentinBrosse QuentinBrosse changed the title Revert "feature: cli s3 integration (#529)" feat: remove s3 integration Sep 10, 2019
jerome-quere
jerome-quere approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit d5ec863 into scaleway:master Sep 10, 2019
@QuentinBrosse QuentinBrosse deleted the remove-s3-command branch November 13, 2019 14:36
@remyleone remyleone added the object Object storage issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jerome-quere jerome-quere jerome-quere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

object Object storage issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuentinBrosse @jerome-quere @remyleone