feat(core): print a warning when new release is available #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jan 31, 2020
kindermoumoute
changed the title
kindermoumoute
force-pushed
the
check-version
branch
from
dfef1f0 to
9be9904
Compare
jerome-quere
suggested changes
Feb 3, 2020
internal/core/bootstrap.go
Outdated
| // Check CLI new version | ||
| if interactive.IsInteractive { | ||
| defer func() { | ||
| config.BuildInfo.checkVersion() |
Contributor
There was a problem hiding this comment.
The warning should be print before result not after.
loicbourgois
suggested changes
Feb 4, 2020
loicbourgois
suggested changes
Feb 4, 2020
kindermoumoute
force-pushed
the
check-version
branch
5 times, most recently
from
b0639bd to
4c03994
Compare
kindermoumoute
force-pushed
the
check-version
branch
from
4c03994 to
2b8ede4
Compare
| logger.Debugf("skipping telemetry report") | ||
| return | ||
| } | ||
| matomoErr := matomo.SendCommandTelemetry(&matomo.SendCommandTelemetryRequest{ |
| } | ||
|
|
||
| const ( | ||
| scwDisableCheckVersionEnv = "SCW_DISABLE_CHECK_VERSION" |
Contributor
There was a problem hiding this comment.
We need to document it somewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.