Skip to content

Conversation

@remyleone
Copy link
Member

No description provided.

@remyleone remyleone self-assigned this Feb 11, 2020
@QuentinBrosse QuentinBrosse changed the title fix(core): Make warning the default logger level fix(core): make warning the default logger level Feb 11, 2020
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to fix Test_CheckVersion/Outdated_version test

@kindermoumoute
Copy link
Contributor

I reverted few changes made in #665 and fixed the goldens

Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit f8af118 into v2 Feb 13, 2020
@kindermoumoute kindermoumoute deleted the APIGW-1882 branch February 13, 2020 13:56
@kindermoumoute kindermoumoute added this to the v2.0.0-alpha.1 milestone Feb 14, 2020
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants