Skip to content

fix(core): make warning the default logger level #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2020
Merged

fix(core): make warning the default logger level #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f1785
fix(core): Make warning the default logger level
remyleone Feb 11, 2020
8ac7485
fix check version golden
kindermoumoute Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/core/build_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func (b *BuildInfo) checkVersion() {
}

if b.Version.LessThan(latestVersion) {
logger.Infof("a new version of scw is available (%s), beware that you are currently running %v", latestVersion, b.Version)
logger.Warningf("a new version of scw is available (%s), beware that you are currently running %v", latestVersion, b.Version)
} else {
logger.Debugf("version is up to date (%s)", b.Version)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/core/cobra_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func cobraPreRunInitMeta(ctx context.Context, cmd *Command) func(cmd *cobra.Comm
var err error
meta := extractMeta(ctx)

logLevel := logger.LogLevelInfo
logLevel := logger.LogLevelWarning
if meta.DebugModeFlag {
logLevel = logger.LogLevelDebug // enable debug mode
}
Expand Down
2 changes: 1 addition & 1 deletion internal/core/testdata/test-check-version-outdated-version.stderr.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
INFO: 2019/12/09 16:04:07 a new version of scw is available (2.0.0-alpha1), beware that you are currently running 1.20.0
WARNING: 2019/12/09 16:04:07 a new version of scw is available (2.0.0-alpha1), beware that you are currently running 1.20.0
2 changes: 1 addition & 1 deletion internal/core/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func validateArgValues(cmd *Command, cmdArgs interface{}) error {
fieldName = strings.ReplaceAll(fieldName, "."+mapSchema, "")
fieldValue, fieldExists := getValueForFieldByName(cmdArgs, fieldName)
if !fieldExists {
logger.Debugf("could not validate arg value for '%v': invalid fieldName: %v", argSpec.Name, fieldName)
logger.Infof("could not validate arg value for '%v': invalid fieldName: %v", argSpec.Name, fieldName)
continue
}
validateFunc := DefaultArgSpecValidateFunc()
Expand Down