feat(loadbalancer): add health check port annotation #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
Partially addresses #192
Summary
This PR introduces a new annotation
service.beta.kubernetes.io/scw-loadbalancer-health-check-portthat allows users to explicitly define the port used for health checks on Scaleway Load Balancers.Motivation
The Scaleway CCM currently determines the LoadBalancer health check port based on the per-port
nodePort. However, there is no simple way to force a specific port for the health check, which is limiting in several use cases:spec.healthCheckNodePortwithexternalTrafficPolicy: LocalChanges
service.beta.kubernetes.io/scw-loadbalancer-health-check-port1808080:10080;443:1044380,8080:10080;9090(port 8888 would use9090)Usage Examples
Testing
Future Work
For full resolution of #192, a follow-up PR could automatically detect and use
spec.healthCheckNodePortwhenexternalTrafficPolicy: Localis set, without requiring manual annotation.