-
Notifications
You must be signed in to change notification settings - Fork 12
chore(deps): bump intl-pluralrules from 1.2.2 to 1.3.0 #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [intl-pluralrules](https://github.com/eemeli/intl-pluralrules) from 1.2.2 to 1.3.0. - [Release notes](https://github.com/eemeli/intl-pluralrules/releases) - [Commits](eemeli/intl-pluralrules@v1.2.2...v1.3.0) --- updated-dependencies: - dependency-name: intl-pluralrules dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 345 345
Branches 55 55
=========================================
Hits 345 345 Continue to review full report at Codecov.
|
chambo-e
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we only support modern browsers which already include Intl.PluralRules shouldn't we delete this polyfill ?
Actually, it is impossible to drop it because we use it in i18n hook and we need to provide the best compatibility we can ? However we can plan to change this in useI18n then drop it ? @chambo-e |
|
@DorianMaliszewski @chambo-e i think we can remove this package now |
|
So we need to drop the import in the hook |
yes absolutely, that what I meant :) |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps intl-pluralrules from 1.2.2 to 1.3.0.
Release notes
Sourced from intl-pluralrules's releases.
Commits
d9e9ff91.3.05feeb1dfeat: Update make-plural to v7, and thereby to CLDR v3906c4387Skip a test due to a V8 bug (still not fixed for Node.js 12 & 14)53d8c9cci: Trigger test workflow on master push, all PRs, and manually8924882chore: Update dependencies, including jest@27c9f237bRevert "Skip a test due to a V8 bug"29f2dcfchore: Update Prettier rules in package.json to match actual practice731aefdci: Update test environments, dropping Node.js 10 & adding 169e44b70Update package-lock.jsonDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)