Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 27, 2021

Bumps intl-pluralrules from 1.2.2 to 1.3.0.

Release notes

Sourced from intl-pluralrules's releases.

v1.3.0

  • Update make-plural to v7, and thereby to CLDR v39
  • Update dependencies, including jest@27
Commits
  • d9e9ff9 1.3.0
  • 5feeb1d feat: Update make-plural to v7, and thereby to CLDR v39
  • 06c4387 Skip a test due to a V8 bug (still not fixed for Node.js 12 & 14)
  • 53d8c9c ci: Trigger test workflow on master push, all PRs, and manually
  • 8924882 chore: Update dependencies, including jest@27
  • c9f237b Revert "Skip a test due to a V8 bug"
  • 29f2dcf chore: Update Prettier rules in package.json to match actual practice
  • 731aefd ci: Update test environments, dropping Node.js 10 & adding 16
  • 9e44b70 Update package-lock.json
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [intl-pluralrules](https://github.com/eemeli/intl-pluralrules) from 1.2.2 to 1.3.0.
- [Release notes](https://github.com/eemeli/intl-pluralrules/releases)
- [Commits](eemeli/intl-pluralrules@v1.2.2...v1.3.0)

---
updated-dependencies:
- dependency-name: intl-pluralrules
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 27, 2021
@dependabot dependabot bot requested review from a team, DorianMaliszewski and chambo-e and removed request for a team August 27, 2021 21:06
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #348 (066854a) into master (d908776) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #348   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          345       345           
  Branches        55        55           
=========================================
  Hits           345       345           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d908776...066854a. Read the comment docs.

Copy link
Contributor

@chambo-e chambo-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we only support modern browsers which already include Intl.PluralRules shouldn't we delete this polyfill ?

@DorianMaliszewski
Copy link
Member

DorianMaliszewski commented Aug 31, 2021

As we only support modern browsers which already include Intl.PluralRules shouldn't we delete this polyfill ?

Actually, it is impossible to drop it because we use it in i18n hook and we need to provide the best compatibility we can ? However we can plan to change this in useI18n then drop it ? @chambo-e

@philibea
Copy link
Collaborator

@DorianMaliszewski @chambo-e i think we can remove this package now
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/PluralRules#browser_compatibility

@DorianMaliszewski
Copy link
Member

So we need to drop the import in the hook

@chambo-e
Copy link
Contributor

So we need to drop the import in the hook

yes absolutely, that what I meant :)
I'll create the PR which will automatically close this PR

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 1, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/intl-pluralrules-1.3.0 branch September 1, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants