Skip to content

Conversation

@Vinzius
Copy link
Contributor

@Vinzius Vinzius commented Nov 4, 2022

Context: the DefaultValues type was only containing default values from a profile, and not the ones from Settings. It leads to some typecheck errors when it's needed in marshallers.

@Vinzius Vinzius requested a review from QuiiBz November 4, 2022 15:13
@Vinzius Vinzius merged commit 252356a into main Nov 4, 2022
@Vinzius Vinzius deleted the fix/defaultvalues branch November 4, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants