Skip to content

fix(client): adjust DefaultValues so it contains defaultPageSize #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix(client): adjust DefaultValues so it contains defaultPageSize #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/clients/src/bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export { isJSONObject } from './helpers/json'
export { waitForResource } from './internal/async/interval-retrier'
export type { WaitForOptions } from './internal/async/interval-retrier'
export { API } from './scw/api'
export type { DefaultValues } from './scw/client-ini-profile'
export type { DefaultValues } from './scw/client-settings'
export type {
Money,
ServiceInfo,
Expand Down
2 changes: 1 addition & 1 deletion packages/clients/src/internals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export type { RequestInterceptor } from './internal/interceptors/request'
export type { ResponseInterceptor } from './internal/interceptors/response'
export { API } from './scw/api'
export { authenticateWithSessionToken } from './scw/auth'
export type { DefaultValues } from './scw/client-ini-profile'
export type { DefaultValues } from './scw/client-settings'
export {
marshalScwFile,
marshalMoney,
Expand Down
4 changes: 2 additions & 2 deletions packages/clients/src/scw/client-ini-profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export interface AuthenticationSecrets {
*
* @public
*/
export interface DefaultValues {
export interface ProfileDefaultValues {
/**
* APIURL overrides the API URL of the Scaleway API to the given URL.
* Change that if you want to direct requests to a different endpoint.
Expand Down Expand Up @@ -65,7 +65,7 @@ export interface DefaultValues {
*
* @public
*/
export type Profile = Partial<DefaultValues & AuthenticationSecrets>
export type Profile = Partial<ProfileDefaultValues & AuthenticationSecrets>

/**
* Verifies that the payload contains both the accessKey and the secretKey.
Expand Down
14 changes: 13 additions & 1 deletion packages/clients/src/scw/client-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,19 @@ import {
isURL,
isZone,
} from '../internal/validations/string-validation'
import type { DefaultValues } from './client-ini-profile'
import type { ProfileDefaultValues } from './client-ini-profile'

/**
* Holds default values of settings.
*
* @public
*/
export type DefaultValues = ProfileDefaultValues & {
/**
* The default number of results when requesting a paginated resource.
*/
defaultPageSize?: number
}

/**
* Settings hold the values of all client options.
Expand Down