Skip to content

fix(errors): adjust message of QuotasExceededError #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

fix(errors): adjust message of QuotasExceededError #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/clients/src/scw/errors/non-standard/__tests__/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('InvalidRequestError', () => {
},
])
expect(error.message).toBe(
'quota exceeded(s): compute_snapshots_type_b_ssd_available has reached its quota (0/0)',
'quota(s) exceeded: compute_snapshots_type_b_ssd_available has reached its quota (0/0)',
)
})

Expand Down
2 changes: 1 addition & 1 deletion packages/clients/src/scw/errors/standard/__tests__/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ describe('QuotasExceededError', () => {

it(`parses a valid input`, () => {
expect(parseScalewayError(403, body).toString()).toBe(
`QuotasExceededError: quota exceeded(s): instance_volume has reached its quota (10/10) for project 'b7a1cf21-1e90-464c-a9f6-375c4d1f4b64'; instance_volumes_l_ssd_total_gb has reached its quota (80/100) for organization '72dd6741-d748-42e7-ba65-acd07447d3e9'; instance_volumes_l_ssd_total_gb has reached its quota (70/100)`,
`QuotasExceededError: quota(s) exceeded: instance_volume has reached its quota (10/10) for project 'b7a1cf21-1e90-464c-a9f6-375c4d1f4b64'; instance_volumes_l_ssd_total_gb has reached its quota (80/100) for organization '72dd6741-d748-42e7-ba65-acd07447d3e9'; instance_volumes_l_ssd_total_gb has reached its quota (70/100)`,
)
})

Expand Down
2 changes: 1 addition & 1 deletion packages/clients/src/scw/errors/standard/quotas-exceeded-error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export type QuotasExceededErrorDetails = {
* @internal
*/
const buildMessage = (list: QuotasExceededErrorDetails[]): string =>
`quota exceeded(s): ${list
`quota(s) exceeded: ${list
.map(details => {
const message = `${details.resource} has reached its quota (${details.current}/${details.quota})`

Expand Down