Skip to content

feat(secret): add secret version CRC32 #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

feat(secret): add secret version CRC32 #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/clients/src/api/secret/v1alpha1/marshalling.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ export const unmarshalAccessSecretVersionResponse = (data: unknown) => {

return {
data: data.data,
dataCrc32: data.data_crc32,
revision: data.revision,
secretId: data.secret_id,
} as AccessSecretVersionResponse
Expand Down Expand Up @@ -124,6 +125,7 @@ export const marshalCreateSecretVersionRequest = (
defaults: DefaultValues,
): Record<string, unknown> => ({
data: request.data,
data_crc32: request.dataCrc32,
description: request.description,
disable_previous: request.disablePrevious,
...resolveOneOf([
Expand Down
13 changes: 13 additions & 0 deletions packages/clients/src/api/secret/v1alpha1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ export interface AccessSecretVersionResponse {
revision: number
/** The base64-encoded secret payload of the version. */
data: string
/**
* The CRC32 checksum of the data as a base-10 integer. This field is present
* only if a CRC32 was supplied during the creation of the version.
*/
dataCrc32: number
}

/** List secret versions response. */
Expand Down Expand Up @@ -220,6 +225,14 @@ export type CreateSecretVersionRequest = {
* set.
*/
passwordGeneration?: PasswordGenerationParams
/**
* The CRC32 checksum of the data as a base-10 integer. This field is optional
* and can be set to 0. If greater than 0, the Secret Manager will verify the
* integrity of the data received against the given CRC32. An error is
* returned if the CRC32 does not match. Otherwise, the CRC32 will be stored
* and returned along with the SecretVersion on futur accesses.
*/
dataCrc32: number
}

export type GetSecretVersionRequest = {
Expand Down