Skip to content

feat(instance): add field zone for PrivateNIC/PrivateNetwork #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

feat(instance): add field zone for PrivateNIC/PrivateNetwork #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scaleway-async/scaleway_async/instance/v1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ def unmarshal_PrivateNIC(data: Any) -> PrivateNIC:
else:
args["tags"] = []

field = data.get("zone", None)
if field is not None:
args["zone"] = field
else:
args["zone"] = None

field = data.get("creation_date", None)
if field is not None:
args["creation_date"] = (
Expand Down Expand Up @@ -4726,6 +4732,11 @@ def marshal_PrivateNIC(
if request.tags is not None:
output["tags"] = request.tags

if request.zone is not None:
output["zone"] = request.zone
else:
output["zone"] = defaults.default_zone

if request.creation_date is not None:
output["creation_date"] = request.creation_date.isoformat()

Expand Down
5 changes: 5 additions & 0 deletions scaleway-async/scaleway_async/instance/v1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,11 @@ class PrivateNIC:
Private NIC tags.
"""

zone: ScwZone
"""
The zone in which the Private NIC is located.
"""

creation_date: Optional[datetime] = None
"""
Private NIC creation date.
Expand Down
11 changes: 11 additions & 0 deletions scaleway/scaleway/instance/v1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ def unmarshal_PrivateNIC(data: Any) -> PrivateNIC:
else:
args["tags"] = []

field = data.get("zone", None)
if field is not None:
args["zone"] = field
else:
args["zone"] = None

field = data.get("creation_date", None)
if field is not None:
args["creation_date"] = (
Expand Down Expand Up @@ -4726,6 +4732,11 @@ def marshal_PrivateNIC(
if request.tags is not None:
output["tags"] = request.tags

if request.zone is not None:
output["zone"] = request.zone
else:
output["zone"] = defaults.default_zone

if request.creation_date is not None:
output["creation_date"] = request.creation_date.isoformat()

Expand Down
5 changes: 5 additions & 0 deletions scaleway/scaleway/instance/v1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,11 @@ class PrivateNIC:
Private NIC tags.
"""

zone: ScwZone
"""
The zone in which the Private NIC is located.
"""

creation_date: Optional[datetime] = None
"""
Private NIC creation date.
Expand Down