Skip to content

feat(interlink): add display_name for pops #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

feat(interlink): add display_name for pops #1324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scaleway-async/scaleway_async/interlink/v1beta1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,12 @@ def unmarshal_Pop(data: Any) -> Pop:
else:
args["available_link_bandwidths_mbps"] = []

field = data.get("display_name", None)
if field is not None:
args["display_name"] = field
else:
args["display_name"] = None

field = data.get("region", None)
if field is not None:
args["region"] = field
Expand Down
5 changes: 5 additions & 0 deletions scaleway-async/scaleway_async/interlink/v1beta1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,11 @@ class Pop:
Available bandwidth in Mbits/s for future hosted links from available connections in this PoP.
"""

display_name: str
"""
Pretty name of the PoP. Includes name, hosting provider and location information (ex: Paris - TeleHouse TH2).
"""

region: ScwRegion
"""
Region of the PoP.
Expand Down
6 changes: 6 additions & 0 deletions scaleway/scaleway/interlink/v1beta1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,12 @@ def unmarshal_Pop(data: Any) -> Pop:
else:
args["available_link_bandwidths_mbps"] = []

field = data.get("display_name", None)
if field is not None:
args["display_name"] = field
else:
args["display_name"] = None

field = data.get("region", None)
if field is not None:
args["region"] = field
Expand Down
5 changes: 5 additions & 0 deletions scaleway/scaleway/interlink/v1beta1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,11 @@ class Pop:
Available bandwidth in Mbits/s for future hosted links from available connections in this PoP.
"""

display_name: str
"""
Pretty name of the PoP. Includes name, hosting provider and location information (ex: Paris - TeleHouse TH2).
"""

region: ScwRegion
"""
Region of the PoP.
Expand Down