Skip to content

chore: clean up ahead of release #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cyclimse merged 10 commits into from
Jan 20, 2023
Merged

chore: clean up ahead of release #26

cyclimse merged 10 commits into from
Jan 20, 2023

Conversation

@cyclimse
Copy link
Contributor

@cyclimse cyclimse commented Jan 18, 2023 •
edited
Loading

Description

Some clean up ahead of the release:

  • removed references to previous documentation deployment
  • upgraded linting thanks to pre-commit.ci
  • fix remaining linting errors
  • updated scaleway-sdk to 0.0.5 (sorry it's out-of-scope but the only relevant change is the deprecation of positional arguments)

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • I have added unit test covering every changes I have made
  • I have updated the relevant documentation

@cyclimse cyclimse requested review from Shillaker and thibaultjunin and removed request for Shillaker and thibaultjunin January 18, 2023 14:36
@cyclimse cyclimse changed the title docs: clean up docs ahead of release chore: clean up ahead of release Jan 18, 2023
@cyclimse cyclimse merged commit 63dd4c5 into main Jan 20, 2023
@cyclimse cyclimse deleted the clean-up-doc branch January 20, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Shillaker Shillaker Shillaker approved these changes

@thibaultjunin thibaultjunin thibaultjunin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyclimse @Shillaker @thibaultjunin