Skip to content

fix(instance): fix default for delete_on_termination #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2021
Merged

fix(instance): fix default for delete_on_termination #740

merged 2 commits into from
Jan 7, 2021

Conversation

@remyleone
Copy link
Member

No description provided.

kindermoumoute
kindermoumoute reviewed Jan 7, 2021
View reviewed changes
@remyleone @kindermoumoute
Update scaleway/resource_instance_server.go
0aaeb11 
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
kindermoumoute
kindermoumoute approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 98e7aea into scaleway:master Jan 7, 2021
@remyleone remyleone deleted the fix_minimal1 branch January 7, 2021 14:35
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees

No one assigned

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remyleone @kindermoumoute