Add mongodb driver checks#2363
Conversation
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development/8.1 #2363 +/- ##
===================================================
+ Coverage 68.96% 69.59% +0.63%
===================================================
Files 219 219
Lines 17612 17652 +40
Branches 3621 3606 -15
===================================================
+ Hits 12146 12285 +139
+ Misses 5450 5351 -99
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0954ce7 to
1c8236e
Compare
|
/create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
History mismatchMerge commit #2de80d5a6cbb18f8df31a82d3029d2462da8b1e3 on the integration branch It is likely due to a rebase of the branch Please use the The following options are set: create_integration_branches |
- We should ensure we consider properly the returned flags from MongoDB. - The coverage of MongoClientInterface is increased as well, to also test the new logic. Issue: ARSN-488
|
/reset |
Reset completeI have successfully deleted this pull request's integration branches. The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-488. Goodbye williamlardier. The following options are set: approve, create_integration_branches |
Catching errors might not be enough: in some cases, a call can succeed yet the result is not what we expect: e.g. no document matching the filters. This leads to inconsistent behaviors where the API thinks the operation succeed while it didn't...
In this PR we identify and fix multiple places where we are ignoring MongoDB return flags. We add the error handling and multiple tests are added, as today some methods are not unit tested at all.
Issue: ARSN-488