Skip to content

Add mongodb driver checks#2363

Merged
bert-e merged 2 commits intodevelopment/8.1from
bugfix/ARSN-488
May 21, 2025
Merged

Add mongodb driver checks#2363
bert-e merged 2 commits intodevelopment/8.1from
bugfix/ARSN-488

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 24, 2025

Catching errors might not be enough: in some cases, a call can succeed yet the result is not what we expect: e.g. no document matching the filters. This leads to inconsistent behaviors where the API thinks the operation succeed while it didn't...

In this PR we identify and fix multiple places where we are ignoring MongoDB return flags. We add the error handling and multiple tests are added, as today some methods are not unit tested at all.

Issue: ARSN-488

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 24, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@ghost ghost force-pushed the bugfix/ARSN-488 branch from 1e3e78b to d0ba24d Compare April 24, 2025 12:54
@ghost ghost deleted a comment from bert-e Apr 24, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 24, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@ghost ghost force-pushed the bugfix/ARSN-488 branch from d0ba24d to aa8e269 Compare April 24, 2025 13:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.59%. Comparing base (cd64d2d) to head (fa8e785).
Report is 2 commits behind head on development/8.1.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.1    #2363      +/-   ##
===================================================
+ Coverage            68.96%   69.59%   +0.63%     
===================================================
  Files                  219      219              
  Lines                17612    17652      +40     
  Branches              3621     3606      -15     
===================================================
+ Hits                 12146    12285     +139     
+ Misses                5450     5351      -99     
  Partials                16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghost ghost force-pushed the bugfix/ARSN-488 branch 11 times, most recently from 0954ce7 to 1c8236e Compare May 2, 2025 09:36
@ghost
Copy link
Copy Markdown
Author

ghost commented May 2, 2025

/create_integration_branches

@ghost ghost force-pushed the bugfix/ARSN-488 branch from 1c8236e to 2de80d5 Compare May 2, 2025 09:43
@ghost ghost deleted a comment from bert-e May 2, 2025
@ghost ghost deleted a comment from bert-e May 2, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 2, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

Comment thread package.json Outdated
@ghost ghost requested a review from francoisferrand May 2, 2025 09:50
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts
@ghost ghost force-pushed the bugfix/ARSN-488 branch from 4919cf3 to a0dcf44 Compare May 2, 2025 13:25
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 2, 2025

History mismatch

Merge commit #2de80d5a6cbb18f8df31a82d3029d2462da8b1e3 on the integration branch
w/8.2/bugfix/ARSN-488 is merging a branch which is neither the current
branch bugfix/ARSN-488 nor the development branch
development/8.2.

It is likely due to a rebase of the branch bugfix/ARSN-488 and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

@ghost ghost force-pushed the bugfix/ARSN-488 branch from a0dcf44 to 507987f Compare May 5, 2025 08:13
@ghost ghost requested a review from francoisferrand May 5, 2025 08:35
@ghost ghost assigned benzekrimaha May 5, 2025
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated
@ghost ghost force-pushed the bugfix/ARSN-488 branch from 507987f to 80fcfbd Compare May 6, 2025 08:48
@ghost ghost requested a review from benzekrimaha May 6, 2025 08:50
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated
Comment thread package.json Outdated
@ghost ghost requested a review from welansari May 20, 2025 14:01
Seragonia added 2 commits May 21, 2025 11:24
- We should ensure we consider properly the returned flags from
  MongoDB.
- The coverage of MongoClientInterface is increased as well, to
  also test the new logic.

Issue: ARSN-488
@ghost ghost force-pushed the bugfix/ARSN-488 branch from 80fcfbd to fa8e785 Compare May 21, 2025 09:24
@ghost
Copy link
Copy Markdown
Author

ghost commented May 21, 2025

/reset

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 21, 2025

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

@ghost ghost deleted a comment from bert-e May 21, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 21, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@ghost
Copy link
Copy Markdown
Author

ghost commented May 21, 2025

/approve

@bert-e bert-e merged commit fa8e785 into development/8.1 May 21, 2025
7 checks passed
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 21, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue ARSN-488.

Goodbye williamlardier.

The following options are set: approve, create_integration_branches

@bert-e bert-e deleted the bugfix/ARSN-488 branch May 21, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants