Fixes for cloudserver unification#2373
Conversation
Metadata (the component) does return Arsenal errors but not as an instance of the Arsenal errors class. We should keep the same error type instead of returning an internal error. Issue: ARSN-490
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development/8.2 #2373 +/- ##
===================================================
+ Coverage 69.91% 70.05% +0.13%
===================================================
Files 218 218
Lines 17440 17443 +3
Branches 3592 3605 +13
===================================================
+ Hits 12194 12219 +25
+ Misses 5242 5220 -22
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
esp. needs [1] [1] scality/Arsenal#2373 Issue: CLDSRV-638
| * @param err - Error to convert | ||
| * @returns ArsenalError instance | ||
| */ | ||
| export function toArsenalError(err: ArsenalError | Error): ArsenalError { |
There was a problem hiding this comment.
Maybe a candidate for lib/errorUtils.ts? Or a static member of ArsenalError?
There was a problem hiding this comment.
may be generalized as part of the (future, heopfully soon) error rework effort; but at the moment moving it creates more quesitons (should it support other types, possibly using ArsenalError.deserialize...)
esp. needs [1] [1] scality/Arsenal#2373 Issue: CLDSRV-638
b483aef to
6f9f6ad
Compare
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-490. Goodbye francoisferrand. The following options are set: approve |
Issue: ARSN-490