Skip to content

impr: ARSN-563 change error code of RaftSessionLeaderNotConnected to 500#2602

Merged
bert-e merged 2 commits intodevelopment/8.2from
improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500
Mar 31, 2026
Merged

impr: ARSN-563 change error code of RaftSessionLeaderNotConnected to 500#2602
bert-e merged 2 commits intodevelopment/8.2from
improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500

Conversation

@jonathan-gramain
Copy link
Copy Markdown
Contributor

The RaftSessionLeaderNotConnected Arsenal error was mapped to HTTP 400 (client error), but "not connected to the leader" is a server-side condition that the client cannot influence. Change it to 500 (server error) so callers can correctly distinguish it from bad-request errors.

Also update the description to the more human-readable 'not connected to the RAFT session leader'.

The RaftSessionLeaderNotConnected Arsenal error was mapped to HTTP 400
(client error), but "not connected to the leader" is a server-side
condition that the client cannot influence. Change it to 500 (server
error) so callers can correctly distinguish it from bad-request
errors.

Also update the description to the more human-readable 'not connected
to the RAFT session leader'.
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 30, 2026

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 30, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-563 contains:

  • 8.2.49

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.49

  • 8.3.9

Please check the Fix Version/s of ARSN-563, or the target
branch of this pull request.

@jonathan-gramain
Copy link
Copy Markdown
Contributor Author

ping

@claude
Copy link
Copy Markdown

claude bot commented Mar 30, 2026

LGTM — the 400→500 change is correct: "not connected to the leader" is a server-side condition, not a client error.

Minor note: the new description style ('not connected to the RAFT session leader') is lowercase/sentence-style, while most other errors in the file use PascalCase identifiers (e.g. 'NotLeader', 'NoLeaderForDB'). This is called out as intentional in the PR description, just flagging for awareness.

Review by Claude Code

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 30, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@jonathan-gramain
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 31, 2026

Conflict

A conflict has been raised during the creation of
integration branch w/8.3/improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500 with contents from improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500
and development/8.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/8.3/improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500 origin/development/8.3
 git merge origin/improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500
 # <intense conflict resolution>
 git commit
 git push -u origin w/8.3/improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 31, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.2

  • ✔️ development/8.3

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue ARSN-563.

Goodbye jonathan-gramain.

The following options are set: approve

@bert-e bert-e merged commit a4a19a8 into development/8.2 Mar 31, 2026
8 checks passed
@bert-e bert-e deleted the improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500 branch March 31, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants