Improvement/arsn 558 integrate shared prettier#2624
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.4 #2624 +/- ##
================================================
Coverage 73.55% 73.55%
================================================
Files 222 222
Lines 18214 18214
Branches 3774 3798 +24
================================================
Hits 13398 13398
Misses 4811 4811
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
da8d881 to
adb58fc
Compare
|
| "@babel/preset-typescript": "^7.27.1", | ||
| "@eslint/compat": "^1.4.0", | ||
| "@eslint/plugin-kit": "^0.4.0", | ||
| "@scality/eslint-config-scality": "scality/Guidelines#02884035be6a1c9d264cf946e59122b271edda39", |
There was a problem hiding this comment.
Please note that the commit hash will be replaced by the tag before merging once the guidelines tag available
| "@babel/preset-typescript": "^7.27.1", | ||
| "@eslint/compat": "^1.4.0", | ||
| "@eslint/plugin-kit": "^0.4.0", | ||
| "@scality/eslint-config-scality": "scality/Guidelines#02884035be6a1c9d264cf946e59122b271edda39", |
There was a problem hiding this comment.
@scality/eslint-config-scality is pinned to a commit hash instead of a tag. Every other git-based dep in this file uses a tag (httpagent#1.1.0, sproxydclient#8.1.0, werelogs#8.2.2, etc.). The lock file shows this resolves to version 8.3.2 — pin to that tag for consistency and readability.
```suggestion
"@scality/eslint-config-scality": "scality/Guidelines#8.3.2",
|
3272d6b to
849c396
Compare
| "@types/jest": "^29.5.13", | ||
| "@types/node": "^22.7.6", | ||
| "@types/utf8": "^3.0.3", | ||
| "@types/xml2js": "^0.4.14", |
There was a problem hiding this comment.
@scality/eslint-config-scality is pinned to a commit hash (02884035...) instead of a tag. The yarn.lock resolves this to version 8.3.2, but the latest tag in scality/Guidelines is 8.3.1 — no 8.3.2 tag exists yet.
Pin to a tag once 8.3.2 is published, e.g.:
```suggestion
"@scality/eslint-config-scality": "scality/Guidelines#8.3.2",
<br>— Claude Code
Review by Claude Code |
SylvainSenechal
left a comment
There was a problem hiding this comment.
Do you think we need to update Claude.md, skill.md, or the copilot file thing too ? (same comment for other pr related to prettier)
df8bbbe to
329d7bf
Compare
329d7bf to
93c267f
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
|
LGTM |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-558. Goodbye benzekrimaha. The following options are set: approve |
Issue: ARSN-558