Skip to content

Improvement/arsn 558 integrate shared prettier#2624

Merged
bert-e merged 4 commits into
development/8.4from
improvement/ARSN-558-Integrate-shared-prettier
May 15, 2026
Merged

Improvement/arsn 558 integrate shared prettier#2624
bert-e merged 4 commits into
development/8.4from
improvement/ARSN-558-Integrate-shared-prettier

Conversation

@benzekrimaha
Copy link
Copy Markdown
Contributor

@benzekrimaha benzekrimaha commented May 6, 2026

Issue: ARSN-558

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 6, 2026

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 6, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-558 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.4.2

Please check the Fix Version/s of ARSN-558, or the target
branch of this pull request.

@claude
Copy link
Copy Markdown

claude Bot commented May 6, 2026

  • package.json:66@scality/eslint-config-scality is pinned to a raw commit hash (02884035...) instead of a tag. The yarn.lock resolves it to version 8.3.2, but the latest tag on scality/Guidelines is 8.3.1 — so this depends on unreleased code. Pin to a tag once 8.3.2 is released, or at minimum use 8.3.1 if it includes the prettier config. Raw commit hashes make it harder to audit what version is installed and break the convention used by the other git-based deps in this file (werelogs, sproxydclient, httpagent).

    Review by Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.55%. Comparing base (2312744) to head (93c267f).

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.4    #2624   +/-   ##
================================================
  Coverage            73.55%   73.55%           
================================================
  Files                  222      222           
  Lines                18214    18214           
  Branches              3774     3798   +24     
================================================
  Hits                 13398    13398           
  Misses                4811     4811           
  Partials                 5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-558-Integrate-shared-prettier branch from da8d881 to adb58fc Compare May 6, 2026 16:10
@claude
Copy link
Copy Markdown

claude Bot commented May 6, 2026

  • package.json:66@scality/eslint-config-scality is pinned to a raw commit hash (02884035be...) instead of a tag. The resolved version is 8.3.2. If that tag exists in the Guidelines repo, pin to scality/Guidelines#8.3.2 for consistency with the other git-based deps (werelogs#8.2.2, sproxydclient#8.1.0, etc.).

    Review by Claude Code

Comment thread package.json Outdated
"@babel/preset-typescript": "^7.27.1",
"@eslint/compat": "^1.4.0",
"@eslint/plugin-kit": "^0.4.0",
"@scality/eslint-config-scality": "scality/Guidelines#02884035be6a1c9d264cf946e59122b271edda39",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that the commit hash will be replaced by the tag before merging once the guidelines tag available

@benzekrimaha benzekrimaha marked this pull request as ready for review May 11, 2026 12:50
Comment thread package.json Outdated
Comment thread package.json Outdated
"@babel/preset-typescript": "^7.27.1",
"@eslint/compat": "^1.4.0",
"@eslint/plugin-kit": "^0.4.0",
"@scality/eslint-config-scality": "scality/Guidelines#02884035be6a1c9d264cf946e59122b271edda39",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scality/eslint-config-scality is pinned to a commit hash instead of a tag. Every other git-based dep in this file uses a tag (httpagent#1.1.0, sproxydclient#8.1.0, werelogs#8.2.2, etc.). The lock file shows this resolves to version 8.3.2 — pin to that tag for consistency and readability.

```suggestion
"@scality/eslint-config-scality": "scality/Guidelines#8.3.2",

@claude
Copy link
Copy Markdown

claude Bot commented May 11, 2026

  • @scality/eslint-config-scality is pinned to a commit hash (0288403...) instead of a tag — breaks the project convention used by all other git-based deps. Pin to 8.3.2 instead.
    - Use scality/Guidelines#8.3.2 to match the pattern of httpagent#1.1.0, sproxydclient#8.1.0, werelogs#8.2.2, etc.

    Review by Claude Code

@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-558-Integrate-shared-prettier branch from 3272d6b to 849c396 Compare May 11, 2026 15:46
@benzekrimaha benzekrimaha requested review from a team, SylvainSenechal and delthas May 11, 2026 15:46
Comment thread package.json
"@types/jest": "^29.5.13",
"@types/node": "^22.7.6",
"@types/utf8": "^3.0.3",
"@types/xml2js": "^0.4.14",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scality/eslint-config-scality is pinned to a commit hash (02884035...) instead of a tag. The yarn.lock resolves this to version 8.3.2, but the latest tag in scality/Guidelines is 8.3.1 — no 8.3.2 tag exists yet.

Pin to a tag once 8.3.2 is published, e.g.:

```suggestion
"@scality/eslint-config-scality": "scality/Guidelines#8.3.2",

<br>— Claude Code

@claude
Copy link
Copy Markdown

claude Bot commented May 11, 2026

  • @scality/eslint-config-scality is pinned to a commit hash instead of a tag — version 8.3.2 has not been tagged in scality/Guidelines yet (latest is 8.3.1)
    • Publish a 8.3.2 tag in the Guidelines repo, then update package.json to reference scality/Guidelines#8.3.2

Review by Claude Code

Copy link
Copy Markdown
Contributor

@SylvainSenechal SylvainSenechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to update Claude.md, skill.md, or the copilot file thing too ? (same comment for other pr related to prettier)

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 15, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-558 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.4.3

Please check the Fix Version/s of ARSN-558, or the target
branch of this pull request.

@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-558-Integrate-shared-prettier branch from df8bbbe to 329d7bf Compare May 15, 2026 12:30
@scality scality deleted a comment from bert-e May 15, 2026
@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-558-Integrate-shared-prettier branch from 329d7bf to 93c267f Compare May 15, 2026 12:40
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 15, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e May 15, 2026
@benzekrimaha
Copy link
Copy Markdown
Contributor Author

/approve

@claude
Copy link
Copy Markdown

claude Bot commented May 15, 2026

LGTM

Review by Claude Code

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 15, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.4

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1
  • development/8.2
  • development/8.3

Please check the status of the associated issue ARSN-558.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit 93c267f into development/8.4 May 15, 2026
9 checks passed
@bert-e bert-e deleted the improvement/ARSN-558-Integrate-shared-prettier branch May 15, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants