Skip to content

Comments

Extend IP and SSL tests#2203

Merged
bert-e merged 2 commits intodevelopment/2.11from
bugfix/ZENKO-4929-complete-ssl-ip-tests
Mar 19, 2025
Merged

Extend IP and SSL tests#2203
bert-e merged 2 commits intodevelopment/2.11from
bugfix/ZENKO-4929-complete-ssl-ip-tests

Conversation

@ghost
Copy link

@ghost ghost commented Mar 18, 2025

  • Add an IP test that was missing, on the happy path with the correct IP range.
  • Add SSL tests.

Issue: ZENKO-4929

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2025

Incorrect fix version

The Fix Version/s in issue ZENKO-4929 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.11.0

Please check the Fix Version/s of ZENKO-4929, or the target
branch of this pull request.

@ghost ghost requested review from benzekrimaha and welansari March 19, 2025 08:41
@bert-e
Copy link
Contributor

bert-e commented Mar 19, 2025

Incorrect fix version

The Fix Version/s in issue ZENKO-4929 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.11.1

Please check the Fix Version/s of ZENKO-4929, or the target
branch of this pull request.

Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Add an IP test that was missing, on the happy path with the
  correct IP range.
- Add SSL tests.

Issue: ZENKO-4929
@ghost ghost force-pushed the bugfix/ZENKO-4929-complete-ssl-ip-tests branch from 06a7401 to 1dd2dd0 Compare March 19, 2025 09:09
@bert-e
Copy link
Contributor

bert-e commented Mar 19, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@ghost
Copy link
Author

ghost commented Mar 19, 2025

I pushed new commits to rebase after the last zenko bump, to avoid one more merge build.

@ghost
Copy link
Author

ghost commented Mar 19, 2025

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 19, 2025

Build failed

The build for commit did not succeed in branch bugfix/ZENKO-4929-complete-ssl-ip-tests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 19, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.11

The following branches have NOT changed:

  • development/2.10
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ZENKO-4929.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit 1dd2dd0 into development/2.11 Mar 19, 2025
14 checks passed
@bert-e bert-e deleted the bugfix/ZENKO-4929-complete-ssl-ip-tests branch March 19, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants