Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 7, 2025

Adding SUR API backend (exposed) to Zenko. CTST tests are added.

@bert-e
Copy link
Contributor

bert-e commented May 7, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 7, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@ghost ghost requested review from benzekrimaha and francoisferrand May 7, 2025 09:56
Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seragonia added 10 commits May 12, 2025 12:45
- Share the same logic as the quota initialization
- Improve the policy attachment step to be more configurable from
  the feature files
- Test that SUR API is exposed, authv4 works for both Roles and
  Users, and ensure authz is working as well. The actual check
  on the metrics is flexible, as this is already tested in SUR
  repository.

Issue: ZENKO-4838
- Required to build scubaclient

Issue: ZENKO-4838
- Added support for location in the MetricsClass

Issue: ZENKO-4838
@ghost ghost force-pushed the improvement/ZENKO-4838-sur-api-2 branch from ddb6df2 to fd2fc2d Compare May 12, 2025 10:46
@ghost
Copy link
Author

ghost commented May 12, 2025

/approve

@bert-e
Copy link
Contributor

bert-e commented May 12, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.12

The following branches have NOT changed:

  • development/2.10
  • development/2.11
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ZENKO-4838.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit fd2fc2d into development/2.12 May 12, 2025
15 checks passed
@bert-e bert-e deleted the improvement/ZENKO-4838-sur-api-2 branch May 12, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants