Merged
Conversation
Contributor
|
Nice to have: I did not see a test regarding the promotion of a build. This would be really nice to have in order to fully validate those optimizations. |
62c00b8 to
3d9e99a
Compare
Contributor
Author
https://github.com/scality/artifacts/pull/213/changes#diff-019e68f115c410de17a78789e0eaaf5260ae05195c2e21714eb07983f8998ab4R74-R88 should do the job |
3d9e99a to
1ac00c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve copy s3 to s3 (promote command)
This pull request updates the object copying logic in
lua/copy_build.luato improve efficiency and performance by introducing batch processing. Instead of copying objects one at a time, the code now processes them in batches usingngx.location.capture_multi, which allows multiple requests to be sent concurrently.Performance improvements to object copying:
ngx.location.capture_multifor concurrent HTTP requests, instead of copying objects one at a time.