Skip to content

INTEGRATION [PR#2635 > development/9.0] BB-676: Ignore bucket migration oplog operations#2640

Merged
bert-e merged 6 commits intodevelopment/9.0from
w/9.0/improvement/BB-676
Apr 8, 2025
Merged

INTEGRATION [PR#2635 > development/9.0] BB-676: Ignore bucket migration oplog operations#2640
bert-e merged 6 commits intodevelopment/9.0from
w/9.0/improvement/BB-676

Conversation

@bert-e
Copy link
Copy Markdown
Contributor

@bert-e bert-e commented Apr 8, 2025

This pull request has been created automatically.
It is linked to its parent pull request #2635.

Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/9.0/improvement/BB-676, please follow this
procedure:

 $ git fetch
 $ git checkout w/9.0/improvement/BB-676
 $ # <amend or cancel the changeset by _adding_ new commits>
 $ git push origin w/9.0/improvement/BB-676

Please always comment pull request #2635 instead of this one.

dvasilas and others added 4 commits April 7, 2025 18:29
In the context of handling bucket migration
in SUR, we have introduced a new type of
operations that appear in the Metadata oplog
and are consumed by Backbeat.

These are “appended” operations, they appear
in the oplog in order to pass information to oplog
consumers, but do not incur any change in the database state.

The format of new operation type is (using an example):
    {
      "db": "some-bucket",
      "method": 10,
      "entries": [
        {
          "type": "bucket_migration_stage",
          "value": "{ ... }"
        }
      ],
      "timestamp": "2025-04-03T06:36:50.401Z"
    },

method: 10 is a new method type, APPEND_TO_LOG.

To make sure that Backbeat ignores these operations
and any operations added in the future
(until we excplictly want to support new operations),
this change adds a check for operations that are known
and supported by Backbeat.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.08%. Comparing base (0476b3b) to head (a52bc1d).
Report is 6 commits behind head on development/9.0.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/queuePopulator/LogReader.js 71.07% <100.00%> (-1.40%) ⬇️

... and 4 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 75.37% <ø> (ø)
Core Library 79.62% <100.00%> (-0.10%) ⬇️
Ingestion 70.14% <ø> (ø)
Lifecycle 76.88% <ø> (-0.21%) ⬇️
Oplog Populator 85.06% <ø> (ø)
Replication 58.55% <ø> (-0.04%) ⬇️
Bucket Scanner 85.60% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.0    #2640      +/-   ##
===================================================
- Coverage            73.16%   73.08%   -0.09%     
===================================================
  Files                  201      201              
  Lines                13373    13377       +4     
===================================================
- Hits                  9785     9776       -9     
- Misses                3578     3591      +13     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.48% <0.00%> (-0.01%) ⬇️
api:routes 9.29% <0.00%> (-0.01%) ⬇️
bucket-scanner 85.60% <ø> (ø)
ft_test:queuepopulator 8.90% <0.00%> (-0.97%) ⬇️
ingestion 12.55% <0.00%> (-0.01%) ⬇️
lib 7.33% <0.00%> (+<0.01%) ⬆️
lifecycle 18.76% <0.00%> (+<0.01%) ⬆️
notification 1.06% <0.00%> (-0.01%) ⬇️
replication 18.52% <0.00%> (-0.01%) ⬇️
unit 48.67% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dvasilas added 2 commits April 8, 2025 09:43
In the context of handling bucket migration
in SUR, we have introduced a new type of
operations that appear in the Metadata oplog
and are consumed by Backbeat.

These are “appended” operations, they appear
in the oplog in order to pass information to oplog
consumers, but do not incur any change in the database state.

The format of new operation type is (using an example):
    {
      "db": "some-bucket",
      "method": 10,
      "entries": [
        {
          "type": "bucket_migration_stage",
          "value": "{ ... }"
        }
      ],
      "timestamp": "2025-04-03T06:36:50.401Z"
    },

method: 10 is a new method type, APPEND_TO_LOG.

To make sure that Backbeat ignores these operations
and any operations added in the future
(until we excplictly want to support new operations),
this change adds a check for operations that are known
and supported by Backbeat.
@bert-e bert-e merged commit a52bc1d into development/9.0 Apr 8, 2025
10 checks passed
@bert-e bert-e deleted the w/9.0/improvement/BB-676 branch April 8, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants