Fix PendingHotfixVersionReminder posting on every run#265
Merged
charlesprost merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
Two bugs caused the reminder to post more than once: 1. NEVER_REPEAT (None) bypassed the history check in _send_comment because `if None:` is falsy. Fixed with `!= 0` in the previous commit on main. 2. The standard dedup uses the full rendered message as the match key, which includes the active_options footer. When active_options changes between runs (e.g. create_integration_branches is added), the footer differs and find_comment misses the existing comment, causing a second post. Fixed by adding an explicit title-prefix pre-check in _notify_pending_hotfix_if_needed using the stable heading '# Pending hotfix branch', which is footer-independent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 89.19% 89.28% +0.09%
==========================================
Files 77 77
Lines 10265 10287 +22
==========================================
+ Hits 9156 9185 +29
+ Misses 1109 1102 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cover the two paths added by the active_options footer fix: - comment not yet in history → notify_user is called - comment already in history → notify_user is skipped Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dont_repeat_if_in_historydedup uses the full rendered message as the match key, which includes theactive_optionsfooter.active_optionschanges between runs (e.g.create_integration_branchesis added), the footer differs →find_commentmisses the existing comment → second post.*The following options are set:* **create_integration_branches**._notify_pending_hotfix_if_neededusing the stable heading# Pending hotfix branch, which is footer-independent.Note: also bundles the
NEVER_REPEAT=Nonebypass fix from main (commit 1c4f76c), since this branch diverges from that point.Test plan
TestQueueing.test_dev_pr_reminder_about_pre_ga_hotfixpassesactive_optionschanges between runs🤖 Generated with Claude Code