bugfix: CLDSRV-291 test for HEAD object with bucket policy#4851
bugfix: CLDSRV-291 test for HEAD object with bucket policy#4851bert-e merged 2 commits intodevelopment/7.10from
Conversation
Add unit tests to show that HEAD object requests are allowed when bucket policy grants the `s3:GetObject` permission to another account or user
Hello jonathan-gramain,My role is to assist you with the merge of this Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
|
ping |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.4/bugfix/CLDSRV-291-testObjectHeadWithBucketPolicy origin/development/8.4
$ git merge origin/w/7.70/bugfix/CLDSRV-291-testObjectHeadWithBucketPolicy
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.4/bugfix/CLDSRV-291-testObjectHeadWithBucketPolicy |
| }); | ||
|
|
||
| it('should allow access to non-object owner for objectHead action with s3:GetObject permission', | ||
| function itFn(done) { |
There was a problem hiding this comment.
why no arrow function like in the previous tests?
There was a problem hiding this comment.
It's to access the this variable, actually most of the previous tests have an actual function for that reason
| done(); | ||
| }); | ||
| it('should deny access to non-object owner for objectHead action without s3:GetObject permission', | ||
| function itFn(done) { |
There was a problem hiding this comment.
same question as above.
jonathan-gramain
force-pushed
the
bugfix/CLDSRV-291-testObjectHeadWithBucketPolicy
branch
from
daab172 to
9505422
Compare
History mismatchMerge commit #daab1729ef0ec0ff3012ebc1127841c4efcf7d84 on the integration branch It is likely due to a rebase of the branch Please use the |
|
/reset |
Reset completeI have successfully deleted this pull request's integration branches. |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.4/bugfix/CLDSRV-291-testObjectHeadWithBucketPolicy origin/development/8.4
$ git merge origin/w/7.70/bugfix/CLDSRV-291-testObjectHeadWithBucketPolicy
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.4/bugfix/CLDSRV-291-testObjectHeadWithBucketPolicy |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
History mismatchMerge commit #6325b175625ba06109baa1c9772563b5f4790d53 on the integration branch It is likely due to a rebase of the branch Please use the |
|
ping |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-291. Goodbye jonathan-gramain. |
4 participants
Add unit tests to show that HEAD object requests are allowed when bucket policy grants the
s3:GetObjectpermission to another account or user