S3C-717: Rework ft tests backbeat to run in e2e S3C Integration#5915
S3C-717: Rework ft tests backbeat to run in e2e S3C Integration#5915BourgoisMickael wants to merge 2 commits intodevelopment/9.0from
Conversation
BourgoisMickael
commented
Aug 25, 2025
- Replace hardcoded credentials
- Replace hardcoded location
There is no account1 in mem_credentials, we use default Replace hardcoded credentials so it can run in end to end tests
Replace hardcoded us-east-1 with a location from config So it can run in an end to end tests for S3C
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect Jira projectThe Jira issue S3C-717 specified in the source |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors functional test files for Backbeat to support e2e S3C Integration testing by replacing hardcoded credentials and location values with dynamic configuration.
- Replace hardcoded AWS credentials (
accessKey1,verySecretKey1) with credentials from the S3 client configuration - Replace hardcoded location (
us-east-1) with dynamic location determination based on S3 hostname - Refactor test setup by moving bucket utility initialization to module level and simplifying before hooks
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/functional/backbeat/listNullVersion.js | Updates credentials to use S3 config and simplifies before hooks |
| tests/functional/backbeat/listLifecycleOrphanDeleteMarkers.js | Updates credentials to use S3 config and simplifies before hooks |
| tests/functional/backbeat/listLifecycleNonCurrents.js | Updates credentials and adds dynamic location detection based on hostname |
| tests/functional/backbeat/listLifecycleCurrents.js | Updates credentials and adds dynamic location detection based on hostname |
| tests/functional/backbeat/listDeleteMarker.js | Updates credentials to use S3 config and simplifies before hooks |
| tests/functional/backbeat/excludedDataStoreName.js | Updates credentials and adds dynamic location detection based on hostname |
| tests/functional/backbeat/bucketIndexing.js | Updates credentials and improves error handling in before hook |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/9.0 #5915 +/- ##
================================================
Coverage 83.19% 83.19%
================================================
Files 188 188
Lines 12093 12093
================================================
Hits 10061 10061
Misses 2032 2032
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
bad branch name for bert-e, had to reopen #5916 |