Skip to content

S3C-717: Rework ft tests backbeat to run in e2e S3C Integration#5915

Closed
BourgoisMickael wants to merge 2 commits intodevelopment/9.0from
improvement/S3C-717-backbeat-tests
Closed

S3C-717: Rework ft tests backbeat to run in e2e S3C Integration#5915
BourgoisMickael wants to merge 2 commits intodevelopment/9.0from
improvement/S3C-717-backbeat-tests

Conversation

@BourgoisMickael
Copy link
Copy Markdown
Contributor

  • Replace hardcoded credentials
  • Replace hardcoded location

There is no account1 in mem_credentials, we use default
Replace hardcoded credentials so it can run in end to end tests
Replace hardcoded us-east-1 with a location from config
So it can run in an end to end tests for S3C
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Aug 25, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Aug 25, 2025

Incorrect Jira project

The Jira issue S3C-717 specified in the source
branch name, does not belong to project CLDSRV.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors functional test files for Backbeat to support e2e S3C Integration testing by replacing hardcoded credentials and location values with dynamic configuration.

  • Replace hardcoded AWS credentials (accessKey1, verySecretKey1) with credentials from the S3 client configuration
  • Replace hardcoded location (us-east-1) with dynamic location determination based on S3 hostname
  • Refactor test setup by moving bucket utility initialization to module level and simplifying before hooks

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/functional/backbeat/listNullVersion.js Updates credentials to use S3 config and simplifies before hooks
tests/functional/backbeat/listLifecycleOrphanDeleteMarkers.js Updates credentials to use S3 config and simplifies before hooks
tests/functional/backbeat/listLifecycleNonCurrents.js Updates credentials and adds dynamic location detection based on hostname
tests/functional/backbeat/listLifecycleCurrents.js Updates credentials and adds dynamic location detection based on hostname
tests/functional/backbeat/listDeleteMarker.js Updates credentials to use S3 config and simplifies before hooks
tests/functional/backbeat/excludedDataStoreName.js Updates credentials and adds dynamic location detection based on hostname
tests/functional/backbeat/bucketIndexing.js Updates credentials and improves error handling in before hook

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.19%. Comparing base (0cbe863) to head (5edaf83).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           development/9.0    #5915   +/-   ##
================================================
  Coverage            83.19%   83.19%           
================================================
  Files                  188      188           
  Lines                12093    12093           
================================================
  Hits                 10061    10061           
  Misses                2032     2032           
Flag Coverage Δ
ceph-backend-test 65.67% <ø> (ø)
file-ft-tests 66.03% <ø> (ø)
kmip-ft-tests 26.83% <ø> (ø)
mongo-v0-ft-tests 67.88% <ø> (-0.03%) ⬇️
mongo-v1-ft-tests 67.88% <ø> (ø)
multiple-backend 35.30% <ø> (ø)
quota-tests 32.05% <ø> (-0.04%) ⬇️
quota-tests-inflights 34.03% <ø> (ø)
unit 67.28% <ø> (ø)
utapi-v2-tests 33.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

bad branch name for bert-e, had to reopen #5916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants